Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to perform ALTER ONLINE is not available when we edit an existing column #16723

Closed
nunoperalta opened this issue Mar 9, 2021 · 5 comments · Fixed by #16850
Closed

Option to perform ALTER ONLINE is not available when we edit an existing column #16723

nunoperalta opened this issue Mar 9, 2021 · 5 comments · Fixed by #16850
Assignees
@williamdes
Labels
ui Issues relating to the user interface
Projects
issues
Milestone
5.1.1

Comments

@nunoperalta
Copy link

nunoperalta commented Mar 9, 2021 •
edited

Hello,

I'm using 5.1.0, but the change made by #15312 isn't present to me.

image

However, the change log says:

5.1.0 (2021-02-24)
(...)
issue #15312 Added an option to perform ALTER ONLINE (ALGORITHM=INPLACE) when editing a table structure
@nunoperalta
Copy link
Author

Ah ok! I do see it, when we add a new column. Just not when we edit an existing column:

image

@williamdes williamdes changed the title Option to perform ALTER ONLINE is not available Option to perform ALTER ONLINE is not available when we edit an existing column Mar 12, 2021
@williamdes williamdes added the ui Issues relating to the user interface label Mar 12, 2021
@williamdes
Copy link
Member

Hi @nunoperalta
Thanks for reporting this. Indeed it should be available at column edit

@williamdes
Copy link
Member

Hi @shucon
Would you want to do this one for QA ?

@williamdes williamdes added this to Needs triage in issues via automation Apr 21, 2021
@williamdes williamdes moved this from Needs triage to Reproduced in issues Apr 21, 2021
@shucon
Copy link
Contributor

shucon commented Apr 21, 2021 •
edited

Sure! But I might not be able to work this week due to some unforeseen circumstances. If it's urgent feel free to take it up.

@shucon
Copy link
Contributor

shucon commented Apr 24, 2021

Working on it

@shucon shucon mentioned this issue Apr 25, 2021
Merged
6 tasks
@williamdes williamdes self-assigned this Apr 25, 2021
@williamdes williamdes added this to the 5.1.1 milestone Apr 25, 2021
@williamdes williamdes linked a pull request Apr 25, 2021 that will close this issue
Fix #16723 - ALTER ONLINE option while editing column #16850
Merged
6 tasks
williamdes added a commit that referenced this issue Apr 25, 2021
@williamdes
Merge #16850 - Fix #16723 - Option to perform ALTER ONLINE is not ava…
3e919d6 
…ilable when we edit an existing column

Pull-request: #16850
Fixs: #16723
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 25, 2021
@williamdes
Add a ChangeLog entry for #16723
cfcca0b 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Apr 25, 2021
@nunoperalta nunoperalta mentioned this issue Jul 17, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

Fix #16723 - ALTER ONLINE option while editing column shucon/phpmyadmin
3 participants
@nunoperalta @williamdes @shucon