Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy to clipboard fails for full-width colon #16758

Closed
inecmc opened this issue Mar 25, 2021 · 1 comment
Closed

Copy to clipboard fails for full-width colon #16758

inecmc opened this issue Mar 25, 2021 · 1 comment
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Projects
issues
Milestone
5.1.1

Comments

@inecmc
Copy link
Contributor

inecmc commented Mar 25, 2021

Describe the bug

The Copy to clipboard function works only if the colon is semi-width :.
Some localization (ja and zh_TW) uses full-width ： and causes string split error.

To Reproduce

Steps to reproduce the behavior:

  1. Install 5.10
  2. Change UI language to ja
  3. Run any query
  4. Click the Copy to clipboard button ( クリップボードにコピー)

Expected behavior

Export the query result to clipboard.

Screenshots

pma

Server configuration

  • PHP version: 7.1
  • phpMyAdmin version: 5.1.0

Client configuration

  • Browser: Chrome latest
  • Operating system: macOS

Additional context

None
@williamdes williamdes self-assigned this Mar 27, 2021
@williamdes williamdes added the Bug A problem or regression with an existing feature label Mar 27, 2021
@williamdes williamdes added this to Needs triage in issues via automation Mar 27, 2021
@williamdes williamdes added this to the 5.1.1 milestone Mar 27, 2021
@williamdes williamdes moved this from Needs triage to Reproduced in issues Mar 27, 2021
@williamdes
Copy link
Member

Thank you @inecmc for the detailed report !

williamdes added a commit that referenced this issue Mar 27, 2021
@williamdes
Add a ChangeLog entry for #16647 and #16758
0ae33c4 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Mar 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Milestone
5.1.1
Development

No branches or pull requests
2 participants
@inecmc @williamdes