New lines in text fields are doubled

[svivian]

To Reproduce

Steps to reproduce the behavior:

1. Browse a table that has a TEXT field, with multiple lines
2. Click "full texts" (the <-T-> icon) to expand the table
3. Click to edit inline, make some changes
4. Press Enter or click away to save

Expected behavior

The text to be saved as written.

Screenshots

Every line break is duplicated, so if you have e.g.

My text
here

It shows as

My text

here

The original text is saved correctly, but the display is wrong. And if you click back in to edit the text, the textarea has the extra new lines, so it can get saved with the extra lines after that.

Server configuration

Same issue on localhost and the PMA demo server.

• Operating system: Mac/Linux
• Web server: Apache
• Database version: 5.7.24 / 8.0.18
• PHP version: 7.4
• phpMyAdmin version: 5.1.0 (via git STABLE branch)

Client configuration

• Browser: Chrome
• Operating system: MacOS 11.2.3

[williamdes]

Hi @svivian
Thank you for reporting this issue, I could reproduce it. Indeed there is some transformation done.
I tried to quick search for the cause but will have to continue searching :)

[williamdes]

I tracked down the bug and found #12918 (5588045).
I think this was recently introduced by #16095 (2c7b704)
And that before that the display was good
Disabling css class .pre_wrap seems to remove the issue.

Maybe #12918 should be reverted now

cc @petrduda

[svivian]

Just an FYI, I reverted to 5.0.5 (branch QA_5_0) and the second part of the issue still occurs there - in other words when you click out of the textarea the correct text is shown, but if you click to edit the field again, it does have the duplicate line breaks.

[williamdes]

Just an FYI, I reverted to 5.0.5 (branch QA_5_0) and the second part of the issue still occurs there - in other words when you click out of the textarea the correct text is shown, but if you click to edit the field again, it does have the duplicate line breaks.

Could you checkout QA_5_1 and remove 5588045 from the js dist or js src and re-build the JS files ?
Could you confirm that removing 5588045 does fix all issues?

[svivian]

Yes, that does appear to fix both the table display and the textarea when re-edited.