Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PHP code removes ; from SQL query on Structure snapshot #16789

Closed
liviuconcioiu opened this issue Apr 1, 2021 · 1 comment
Closed

Create PHP code removes ; from SQL query on Structure snapshot #16789

liviuconcioiu opened this issue Apr 1, 2021 · 1 comment
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.1

Comments

@liviuconcioiu
Copy link
Contributor

Describe the bug

When you click on Create PHP code, from Tracking -> Structure snapshot, the PHP code created replaces the ; delimiter with nothing, between queries and creates malformed ones.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Tracking
  2. Click on Create version
  3. Click on Structure snapshot
  4. Click on Create PHP code
  5. See error

Expected behavior

Generated PHP code should not remove ; delimiter between queries.

Screenshots

Original query:
1

Malformed query:
2

Server configuration

  • Operating system: Windows
  • Web server: nginx/1.19.9
  • Database version: 5.7.33
  • PHP version: 8.0.3
  • phpMyAdmin version: 5.2.0-dev+20210331.1bfaec1351

Client configuration

  • Browser: Firefox
  • Operating system: Windows

Additional context

Add any other context about the problem here.
@williamdes williamdes added the Bug A problem or regression with an existing feature label Apr 1, 2021
@williamdes williamdes added this to Needs triage in issues via automation Apr 1, 2021
@williamdes
Copy link
Member

Thank you for the report @liviuconcioiu

@shucon when you have some time would you mind having a look please?

shucon added a commit to shucon/phpmyadmin that referenced this issue Apr 8, 2021
@shucon
Fix phpmyadmin#16789 Missing ; from Create PHP code
fac9992 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@shucon shucon mentioned this issue Apr 8, 2021
Closed
6 tasks
@williamdes williamdes added this to the 5.1.1 milestone Apr 12, 2021
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 12, 2021
@williamdes williamdes moved this from Needs triage to ready to merge in issues Apr 12, 2021
@williamdes williamdes linked a pull request Apr 12, 2021 that will close this issue
Fix #16789 Missing ; from Create PHP code #16800
Closed
6 tasks
@williamdes williamdes self-assigned this Apr 12, 2021
williamdes added a commit that referenced this issue Apr 12, 2021
@williamdes
Add tests for #16789
f9e3824 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 12, 2021
@williamdes
Merge #16800 - Fix #16789 - Missing ; from Create PHP code
557af4d 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 12, 2021
@williamdes
Fix tests for #16789
130f7af 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 12, 2021
@williamdes
Add a ChangeLog entry for #16789
99fb6c2 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Apr 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

Fix #16789 Missing ; from Create PHP code shucon/phpmyadmin
2 participants
@williamdes @liviuconcioiu