Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined index field_name #16790

Closed
liviuconcioiu opened this issue Apr 2, 2021 · 3 comments
Closed

Undefined index field_name #16790

liviuconcioiu opened this issue Apr 2, 2021 · 3 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@liviuconcioiu
Copy link
Contributor

Describe the bug

I've created a table on https://demo.phpmyadmin.net/master-config/. Then I tried to add 3 columns to the same table and I received a notice and a warning. Unfortunately I couldn't reproduce the bug.

Expected behavior

The notice and warning should not be given and the new columns should be created.

Screenshots

Untitled2

Client configuration

  • Browser: Firefox
  • Operating system: Windows

Additional context

Notice in ./libraries/classes/Controllers/Table/StructureController.php#1113
Undefined index: field_name

Backtrace

StructureController.php#184: PhpMyAdmin\Controllers\Table\StructureController->updateColumns()
Routing.php#189: PhpMyAdmin\Controllers\Table\StructureController->save(array)
index.php#18: PhpMyAdmin\Routing::callControllerForRoute(
string '/table/structure/save',
,
,
)

Warning in ./libraries/classes/Controllers/Table/StructureController.php#1113
count(): Parameter must be an array or an object that implements Countable

Backtrace

StructureController.php#184: PhpMyAdmin\Controllers\Table\StructureController->updateColumns()
Routing.php#189: PhpMyAdmin\Controllers\Table\StructureController->save(array)
index.php#18: PhpMyAdmin\Routing::callControllerForRoute(
string '/table/structure/save',
,
,
)
@williamdes
Copy link
Member

Hi @liviuconcioiu
I was unable to reproduce this
Could you give more details on how to reproduce this ?
I checked the code and it can create this warning but that would require to find a way to send an incomplete form

@williamdes williamdes added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Apr 12, 2021
@williamdes williamdes added this to Needs triage in Questions via automation Apr 12, 2021
@williamdes williamdes moved this from Needs triage to Needs a second check to be a bug in Questions Apr 12, 2021
@liviuconcioiu
Copy link
Contributor Author

Hi @williamdes
Unfortunately I couldn't reproduce it.

@williamdes
Copy link
Member

Hi @williamdes
Unfortunately I couldn't reproduce it.

I will add a code safety for it anyway, thanks for trying again

@williamdes williamdes self-assigned this Apr 12, 2021
@williamdes williamdes added Bug A problem or regression with an existing feature and removed question Used when we need feedback from the submitter or when the issue is a question about PMA labels Apr 12, 2021
@williamdes williamdes added this to Needs triage in issues via automation Apr 12, 2021
@williamdes williamdes removed this from Needs a second check to be a bug in Questions Apr 12, 2021
@williamdes williamdes added this to the 5.1.1 milestone Apr 12, 2021
@williamdes williamdes moved this from Needs triage to Not reproduced in issues Apr 12, 2021
williamdes added a commit that referenced this issue Apr 12, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Not reproduced to Closed Apr 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants