Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong links for COLUMN_NAME row values #16792

Closed
liviuconcioiu opened this issue Apr 5, 2021 · 3 comments · Fixed by #16818
Closed

Wrong links for COLUMN_NAME row values #16792

liviuconcioiu opened this issue Apr 5, 2021 · 3 comments · Fixed by #16818
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.1

Comments

@liviuconcioiu
Copy link
Contributor

Describe the bug

Row values for COLUMN_NAME column, from information_schema.COLUMNS have wrong links. Instead of & after index.php?route=/table/structure/change, is written as &.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://demo.phpmyadmin.net/master-config/index.php?route=/sql&db=information_schema&table=COLUMNS
  2. Click on any COLUMN_NAME column values.
  3. See error

Expected behavior

A form to edit the column should appear.

Screenshots

Right now:
Untitled

Expected:
expected

Client configuration

  • Browser: Firefox
  • Operating system: Windows
@williamdes williamdes added the Bug A problem or regression with an existing feature label Apr 5, 2021
@williamdes williamdes added this to the 5.1.1 milestone Apr 5, 2021
@williamdes williamdes added this to Needs triage in issues via automation Apr 5, 2021
@williamdes
Copy link
Member

Thank you for this report @liviuconcioiu
Confirmed on 5.1

@williamdes williamdes mentioned this issue Apr 13, 2021
Merged
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 13, 2021
@williamdes williamdes linked a pull request Apr 13, 2021 that will close this issue
Remove useless htmlspecialchars on URL generation #16818
Merged
@williamdes
Copy link
Member

The fix for this issue will also solve more issues, found this on the error report server:

vsprintf(
string => string 'index.php?route=/database/structure&server=1&db=%251%5C%24s&tbl_type=table',
string => array
)

@williamdes
Copy link
Member

Param Value
Error Type Warning
Error Message vsprintf(): Too few arguments
Exception Type php
phpMyAdmin version 5.1.0-dev
Incident count 90
Link Report#59307

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@williamdes williamdes self-assigned this Apr 16, 2021
williamdes added a commit that referenced this issue Apr 16, 2021
@williamdes
Add ChangeLog entries for e4a985c, df96ee2, deac7cf, a6a982f and #16792
fe306b2 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Apr 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

Remove useless htmlspecialchars on URL generation williamdes/phpmyadmintest
2 participants
@williamdes @liviuconcioiu