Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut keys don't work #16805

Closed
silverqx opened this issue Apr 10, 2021 · 9 comments · Fixed by #16807
Closed

Shortcut keys don't work #16805

silverqx opened this issue Apr 10, 2021 · 9 comments · Fixed by #16807
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.1

Comments

@silverqx
Copy link

silverqx commented Apr 10, 2021 •
edited

These Shortcut keys which are described here don't work:

  • d + s - Go to database structure (Provided you are in database related page)
  • d + f - Search database (Provided you are in database related page)
  • t + s - Go to table structure (Provided you are in table related page)
  • t + f - Search table (Provided you are in table related page)

I tested it on phpmyadmin 5.1.0 and tried Metro and Original theme.

I fastly tried the js selector that is responsible for actual tab switching after keydown (link) and it returns nothing.
@shucon
Copy link
Contributor

shucon commented Apr 10, 2021 •
edited

Looks like the combination shortcuts are not working on master and QA_5_1. Thanks for the report.

cc @williamdes

@silverqx silverqx changed the title Shortcut keys doesn't work Shortcut keys don't work Apr 10, 2021
@shucon
Copy link
Contributor

shucon commented Apr 10, 2021

Working on this.

@shucon
Copy link
Contributor

shucon commented Apr 10, 2021

ac8ecb7 was the first bad commit.

@shucon shucon mentioned this issue Apr 10, 2021
Merged
6 tasks
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Apr 13, 2021
@williamdes williamdes added this to the 5.1.1 milestone Apr 13, 2021
@williamdes williamdes added this to Review in progress in pull-requests Apr 13, 2021
@williamdes williamdes added this to Needs triage in issues via automation Apr 13, 2021
@williamdes williamdes removed this from Review in progress in pull-requests Apr 13, 2021
@williamdes williamdes moved this from Needs triage to ready to merge in issues Apr 13, 2021
@williamdes
Copy link
Member

Ref: fe98bf7

@williamdes williamdes self-assigned this Apr 13, 2021
williamdes added a commit that referenced this issue Apr 13, 2021
@williamdes
Merge #16807 - Fix #16805 - shortcut keys not working
a4482fb 
Pull-request: #16807
Fixes: #16805

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 13, 2021
@williamdes
Add a ChangeLog entry for #16805
35ac729 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Apr 13, 2021
@silverqx
Copy link
Author

Thx 🙏

@williamdes
Copy link
Member

Thx

You can download the (phpMyAdmin 5.1+snapshot) from our website, maybe wait 10min after I sent this message to be sure the CDN cache is purged :)

It will contain the fix

@Sean4134
Copy link

shortcuts doesn’t help

@williamdes
Copy link
Member

shortcuts doesn’t help

what do you mean ?

@silverqx
Copy link
Author

I fastly tried 5.1 snapshot and shortcuts work thx 🤝 @williamdes @shucon

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

Fixes #16805 Fixes shortcut keys shucon/phpmyadmin
4 participants
@silverqx @williamdes @shucon @Sean4134