Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Your SQL query has been executed successfully is shown two times #16810

Closed
liviuconcioiu opened this issue Apr 12, 2021 · 1 comment · Fixed by #16811
Closed

Your SQL query has been executed successfully is shown two times #16810

liviuconcioiu opened this issue Apr 12, 2021 · 1 comment · Fixed by #16811
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.1

Comments

@liviuconcioiu
Copy link
Contributor

Describe the bug

When Drop button at the bottom of the table structure is used, two identical messages are shown, instead of one.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Structure
  2. Select one column or more
  3. Click on Drop
  4. See error

Expected behavior

One message should be shown instead of two.

Screenshots

error7

Server configuration

  • Operating system: Windows
  • Web server: nginx/1.19.9
  • Database version: 5.7.33
  • PHP version: 8.0.3
  • phpMyAdmin version: 5.2.0-dev+20210331.1bfaec1351

Client configuration

  • Browser: Firefox
  • Operating system: Windows
@shucon
Copy link
Contributor

shucon commented Apr 12, 2021

Thanks for the report, I'll take a look at it.

@shucon shucon mentioned this issue Apr 12, 2021
Merged
6 tasks
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Apr 13, 2021
@williamdes williamdes added this to Needs triage in issues via automation Apr 13, 2021
@williamdes williamdes moved this from Needs triage to Reproduced in issues Apr 13, 2021
@williamdes williamdes added this to the 5.1.1 milestone Apr 13, 2021
@williamdes williamdes linked a pull request Apr 13, 2021 that will close this issue
Fix #16810 Fix SQL query shown twice on drop #16811
Merged
6 tasks
@williamdes williamdes self-assigned this Apr 19, 2021
williamdes added a commit that referenced this issue Apr 19, 2021
@williamdes
Merge #16811 - Fix #16810 - Fix SQL query shown twice on drop
ec4df90 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 19, 2021
@williamdes
Add a ChangeLog entry for #16810
191942f 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Apr 19, 2021
This was referenced Apr 20, 2021
Closed
Merged
williamdes added a commit that referenced this issue Apr 23, 2021
@williamdes
Merge #16841 - Fix #16810 - SQL query shown twice on central columns …
db76d19 
…actions

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 23, 2021
@williamdes
Add ChangeLog entries for 622c91c, c16e09b and #16810
70b38c6 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.1
Development

Successfully merging a pull request may close this issue.

Fix #16810 Fix SQL query shown twice on drop shucon/phpmyadmin
#16810 Fixes SQL query shown twice
3 participants
@williamdes @shucon @liviuconcioiu