New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A SyntaxError is thrown when editing a row #16816
Comments
|
I think the table should not have editable rows. @williamdes Thoughts? |
|
IIRC, I agree with Saksham. This database and certain other tables (in the
mysql and information_schema databases) should not allow editing.
|
|
I am quite sure I had this bug on 5.1 series, seems like something allowed all cells to be opened as a text field fixing this bug will fix this one too |
I was unable to find a working version even in QA_4_6. I think it's a really old bug or it's been like this since forever. |
|
Should we fix it just by not allowing editable rows in all tables of |
Thanks for the research ! |
|
At the top is also this: "Current selection does not contain a unique column. Grid edit, checkbox, Edit, Copy and Delete features are not available.". In the error report, it has this line: "message": "JSON.parse: unexpected character at line 1 column 1 of the JSON https://docs.phpmyadmin.net/en/latest/config.html#cfg_RowActionLinksWithoutUnique The error in the error report could be the result of missing input-data in the Ajax call that's fired when the user hits "enter" to save the data. In the HTML generation, the dblclick event should not be assigned to the event which switches this cell to edit mode. |
|
Hi @RichardValvonaUK |
|
Nope. Mine is 4.5.4.1. However, the link provided in the OP's original post is online for everyone to see and a subdomain on the phpMyAdmin website: demo.phpmyadmin.net. |
I bet you are using a Debian or Ubuntu install :) |
I am, yes: Ubuntu. The fact you mention this suggests 4.5.4.1 is only available for these two platforms. A milestone sounds like a plan. I'll see what else I can do. |
Just checked on https://tracker.debian.org/pkg/phpmyadmin and you can probably upgrade your install since I was maybe not right, it does not look like an old packaged version ^^ |
|
Had a JS error when editing the results of |
Are you doing this using the online version or your own? I've forked and downloaded it to my system but I can see that the vendor folder isn't included in the repo which causes a load of errors. I've just tested your query in the online version and it seems to be working as it should. Are you including the backticks? I wasn't but a JS error did appear when including them. |
You need to use a version from the website like the latest 5.1 version in development (phpMyAdmin 5.1+snapshot) or run Note my message was for a request without backticks |
|
I've done that but it was fraught with errors because of an absense of the vendor directory and the autoload php file. |
|
Sorry. Misunderstood what you said. I forked the repository previously but now have downloaded your version and the vendor file is there. |
Going back to the original issue as posted by the OP, with phpMyAdmin 5.1.1 installed on my computer locally, the double-click issue on tables within the |
Describe the bug
A SyntaxError is thrown when editing a row from
performance_schema.events_stages_summary_global_by_event_name.To Reproduce
Steps to reproduce the behavior:
EVENT_NAMEcolumnScreenshots
Client configuration
Additional context
The text was updated successfully, but these errors were encountered: