Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links not passing through url.php #16845

Closed
liviuconcioiu opened this issue Apr 23, 2021 · 1 comment · Fixed by #16848
Closed

Links not passing through url.php #16845

liviuconcioiu opened this issue Apr 23, 2021 · 1 comment · Fixed by #16848
Assignees
Labels
enhancement A feature request for improving phpMyAdmin good first issue
Milestone

Comments

@liviuconcioiu
Copy link
Contributor

liviuconcioiu commented Apr 23, 2021

Describe the bug

I've noticed that a few links don't pass through url.php

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://demo.phpmyadmin.net/master-config/index.php?route=/
  2. See the links for RELEASE_5_1_0-841-ge0c1dea460 and master, found at the bottom of the page
  3. See the link for 5.1.0 found on the right side on version information

Expected behavior

The links should pass through url.php.

Screenshots

1
2
3
4

Client configuration

  • Browser: Firefox
  • Operating system: Windows

Additional context

'https://github.com/phpmyadmin/phpmyadmin/commit/%s'

'https://github.com/phpmyadmin/phpmyadmin/tree/%s'

const url = 'https://www.phpmyadmin.net/files/' + Functions.escapeHtml(encodeURIComponent(data.version)) + '/';

@williamdes
Copy link
Member

Hi
Thank you for reporting this, I would not consider this a a bug but more that it was missed to use the URL system.
I will have to research to know if there is some kind of benefit to change the links you found to use the URL system

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin good first issue labels Apr 23, 2021
@williamdes williamdes added this to Triage zone in Enhancements via automation Apr 23, 2021
@williamdes williamdes moved this from Triage zone to Miscellaneous in Enhancements Apr 23, 2021
@williamdes williamdes self-assigned this Apr 24, 2021
@williamdes williamdes added this to the 5.2.0 milestone Apr 24, 2021
Enhancements automation moved this from Miscellaneous to Done Apr 24, 2021
williamdes added a commit that referenced this issue Apr 24, 2021
Pull-request: #16848
Fixes: #16845
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 24, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin good first issue
Projects
Enhancements
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants