[PHP 8.1] Method mysqli::get_client_info() is deprecated

[williamdes]

Describe the bug

Deprecation Notice in ./libraries/classes/Dbal/DbiMysqli.php#400
 Method mysqli::get_client_info() is deprecated

Backtrace

DatabaseInterface.php#2150: PhpMyAdmin\Dbal\DbiMysqli->getClientInfo()
HomeController.php#180: PhpMyAdmin\DatabaseInterface->getClientInfo()
Routing.php#187: PhpMyAdmin\Controllers\HomeController->index(array)
./../../../../index.php#18: PhpMyAdmin\Routing::callControllerForRoute(
string '/',
,
,
)

To Reproduce

Steps to reproduce the behavior:

1. Go to home page

Server configuration

• PHP version: 8.1
• phpMyAdmin version: 5.1

See: https://php.watch/versions/8.1/mysqli_get_client_info-deprecation

[williamdes]

Hi @Ayesh
Maybe you would want to cover this on https://php.watch/versions/8.1
Ref: php/php-src@7e9f6d2
Maybe ref: php/php-src#6777

[Ayesh]

Thank you so much @williamdes, I just posted mysqli::get_client_info method and mysqli_get_client_info($param) is deprecated with this. Super grateful for the me 🙏🏼.

[williamdes]

Thank you so much @williamdes, I just posted mysqli::get_client_info method and mysqli_get_client_info($param) is deprecated with this. Super grateful for the me 🙏🏼.

Thank you so much for the nice article !

[kamil-tekiela]

Hi. I am curious why did you decide to add conditional call to get_client_info for PHP < 8.1? Why isn't the method call simply replaced with the function call mysqli_get_client_info or the property client_info (if you want to retain OO-style)?

[williamdes]

Hi. I am curious why did you decide to add conditional call to get_client_info for PHP < 8.1? Why isn't the method call simply replaced with the function call mysqli_get_client_info or the property client_info (if you want to retain OO-style)?

Well, its more that I want no side effects on older versions ;)
Even if there is no side effects, just avoiding to create one can save me a lot of time dealing with angry people that I would have broken their workflow

It's a support everyone nicely way of thinking and anyway, this is only my way of thinking ;)
feel free to let us know what you think about it

[kamil-tekiela]

I understand, but this functionality hasn't changed in many years, probably never. See https://phpize.online/?phpses=0671e6bc6998c43b2658bf96372ab42a&sqlses=null&php_version=php5&sql_version=mysql57

You could have used the property in this place instead of checking the PHP version. Can I suggest PR to simplify this?

[williamdes]

I understand, but this functionality hasn't changed in many years, probably never. See https://phpize.online/?phpses=0671e6bc6998c43b2658bf96372ab42a&sqlses=null&php_version=php5&sql_version=mysql57

You could have used the property in this place instead of checking the PHP version. Can I suggest PR to simplify this?

I am not sure, what do you thing @MauricioFauth ?

[MauricioFauth]

We can safely use just return mysqli_get_client_info();. That is what was used before the change to OO style.