The char/varchar textarea minimum height is incorrectly fixed to 7 rows

[setaou]

Describe the bug

The char/varchar textarea minimum height is incorrectly fixed to 7 rows

To Reproduce

1. Configure a small value for $cfg['CharTextareaRows'], like for instance 2 (which is supposed to be the default, according to the documentation)
2. Open the form to edit or insert a record
3. Observe that he textarea is 7 rows tall

Expected behavior

The textarea height is supposed to respect the $cfg['CharTextareaRows'] config option.

Additional context

The issue is located at https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/classes/InsertEdit.php#L584 and has been introduced by PR #14379.
Here we can see $textAreaRows = max($GLOBALS['cfg']['CharTextareaRows'], 7);, which actually sets the lower boundary of CharTextareaRows to 7.

[williamdes]

Bonjour @setaou
Could you post a before and after screenshot please ?

Thank you so much for the detailed report you made !

[setaou]

Here with the pristine version of phpmyadmin and CharTextareaRows set to 2, you can see the textarea is 7 rows tall :

Removing the max() at libraries/classes/InsertEdit.php line 584 makes it respect the requested size of 2 rows :

[williamdes]

Nice, I will have a look ;)

[sonipardeep]

I think, At libraries/classes/InsertEdit.php
It should be $textAreaRows = max(2, $GLOBALS['cfg']['CharTextareaRows']);

instead of
$textAreaRows = max($GLOBALS['cfg']['CharTextareaRows'], 7);

It is because max function returns maximum of two values so it will always return 7 and will not respect $cfg['CharTextareaRows'] = 2;

So we need to supply first argument 2 and second argument $cfg['CharTextareaRows'].

[williamdes]

Hi @setaou
I just re-build the snapshot with the fix, could you test it ?

Link: (phpMyAdmin 5.1+snapshot)

[setaou]

Hi William,
The bug seems fixed in the snapshot.
Thanks for the good work !