Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors inside queries aren't working #16966

Closed
liviuconcioiu opened this issue Jun 15, 2021 · 3 comments
Closed

Anchors inside queries aren't working #16966

liviuconcioiu opened this issue Jun 15, 2021 · 3 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@liviuconcioiu
Copy link
Contributor

Describe the bug

Anchors inside queries aren't working. If you go to https://demo.phpmyadmin.net/master-config/url.php?url=https://dev.mysql.com/doc/refman/8.0/en/logical-operators.html#operator_or you will be redirected to https://dev.mysql.com/doc/refman/8.0/en/logical-operators.html instead of https://dev.mysql.com/doc/refman/8.0/en/logical-operators.html#operator_or.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://demo.phpmyadmin.net/master-config/index.php?route=/table/sql&db=performance_schema&table=accounts
  2. Run SELECT * FROM accounts WHERE 1 = 1 OR 1 = 1;
  3. Click on OR operator inside query.
  4. See error.

Expected behavior

Anchors should work.

Client configuration

  • Browser: Firefox
  • Operating system: Windows
@williamdes
Copy link
Member

Thank you for the report !
Does it affect 5.1 too ?

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jun 15, 2021
@liviuconcioiu
Copy link
Contributor Author

Yes.

@williamdes williamdes added this to the 5.1.2 milestone Jun 15, 2021
@williamdes
Copy link
Member

This is because # should be URL encoded as %23 in order to be part of the redirect URL

@williamdes williamdes self-assigned this Jul 22, 2021
@williamdes williamdes added this to Needs triage in issues via automation Jul 22, 2021
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Jul 22, 2021
williamdes added a commit that referenced this issue Jul 22, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Jul 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants