Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to zxcvbn-ts #16974

Closed
williamdes opened this issue Jun 20, 2021 · 1 comment · Fixed by #16978
Closed

Switch to zxcvbn-ts #16974

williamdes opened this issue Jun 20, 2021 · 1 comment · Fixed by #16978
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
Milestone
5.2.0

Comments

@williamdes
Copy link
Member

Because of dropbox/zxcvbn#290
The zxcvbn project did not receive updates since 2017.

We should now use: https://github.com/zxcvbn-ts/zxcvbn
@williamdes williamdes added this to the 5.2.0 milestone Jun 20, 2021
@williamdes
Copy link
Member Author

williamdes commented Jun 20, 2021 •
edited

Note: because of missing build sources zxcvbn has been removed from phpMyAdmin distributed at Debian.

Ref: https://salsa.debian.org/phpmyadmin-team/phpmyadmin/-/blob/debian/latest/debian/patches/Remove-dfsg-zxcvbn-js.patch

@williamdes williamdes mentioned this issue Jun 20, 2021
Open
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Jun 21, 2021
@Guileas Guileas mentioned this issue Jun 23, 2021
Merged
@MauricioFauth MauricioFauth added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jun 23, 2021
@williamdes williamdes self-assigned this Jun 23, 2021
@williamdes williamdes added this to Triage zone in Enhancements via automation Jun 23, 2021
@williamdes williamdes moved this from Triage zone to Code base in Enhancements Jun 23, 2021
Enhancements automation moved this from Code base to Done Jun 27, 2021
williamdes added a commit that referenced this issue Jun 27, 2021
@williamdes
Add a ChangeLog entry for #16974
9f5d7da 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@BWPanda BWPanda mentioned this issue Jun 18, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
  
Done
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Replace zxcvbn by zxcvbn-ts Guileas/phpmyadmin
2 participants
@MauricioFauth @williamdes