Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Designer] removing a relation tries to remove the internal relation regardless of if the configuration storage is enabled #16982

Closed
williamdes opened this issue Jun 27, 2021 · 2 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Milestone

Comments

@williamdes
Copy link
Member

williamdes commented Jun 27, 2021

Describe the bug

Removing relations on the Designer tries to remove the internal relation even if the configuration storage is not enabled

To Reproduce

Steps to reproduce the behavior:

  1. Go to Designer
  2. Remove a relation

Expected behavior

Remove it without trying to remove the internal relation

Server configuration

  • phpMyAdmin version: 5.1
@williamdes williamdes changed the title 3. [Designer] removing a relation tries to remove the internal relation regardless of if the configuration storage is enabled Jun 27, 2021
@williamdes
Copy link
Member Author

williamdes commented Jun 27, 2021

This should explain reports of:

Warning: Undefined array key "relation"
#2 .\libraries\classes\Database\Designer\Common.php(18): callControllerForRoute
#1 .\libraries\classes\Database\Designer\Common.php(187): index
#0 .\libraries\classes\Database\Designer\Common.php(142): removeRelation

and

Notice: Undefined index: foreign_keys_data
#4 ./libraries/classes/Relation.php(181): getHtmlForInsertEditRow
#3 ./libraries/classes/Relation.php(3455): getHtmlForInsertEditFormColumn
#2 ./libraries/classes/Relation.php(3242): getNullColumn
#1 ./libraries/classes/Relation.php(545): getNullifyCodeForNullColumn
#0 ./libraries/classes/Relation.php(575): searchColumnInForeigners

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jun 27, 2021
@williamdes williamdes added this to the 5.1.2 milestone Jun 27, 2021
@williamdes williamdes added this to Needs triage in issues via automation Jun 27, 2021
@williamdes williamdes added this to In Progress in Designer Jun 27, 2021
@williamdes williamdes moved this from Needs triage to ready to merge in issues Jun 27, 2021
@williamdes
Copy link
Member Author

This is also because the UI does not remove the relation and so the user can re-try to delete the relation, making the second part of the code be triggered.
This issue will be about the front and back end of this issue

williamdes added a commit that referenced this issue Jun 27, 2021
…emove operations

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jun 27, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jun 27, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jun 27, 2021
And fix PHP 7.1 function syntax call

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Jun 27, 2021
issues automation moved this from ready to merge to Closed Jun 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
Designer
In Progress
issues
  
Closed
Development

No branches or pull requests

1 participant