Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save data from gis editor for spatial column #17018

Closed
MoonE opened this issue Jul 18, 2021 · 5 comments · Fixed by #17074
Closed

Cannot save data from gis editor for spatial column #17018

MoonE opened this issue Jul 18, 2021 · 5 comments · Fixed by #17074
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Milestone

Comments

@MoonE
Copy link
Contributor

MoonE commented Jul 18, 2021

Describe the bug

Cannot save data from gis editor for spatial column.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the insert form on a table with 'Point' column (or any other spatial column)
  2. Click on 'Edit/Insert' for the Point column
  3. Click 'Copy' to get 'POINT(0 0),' 0 into the form
  4. Click 'Save'
  5. It tries to execute an invalid query: INSERT INTO `test` (`id`, `point`) VALUES (NULL, '\'POINT(0 0)\',0')
    Instead of INSERT INTO `test` (`id`, `point`) VALUES (NULL, ST_PointFromText('POINT(0 0)',0))

Expected behavior

A new row should be inserted without error

Screenshots

image

Server configuration

  • Operating system:
  • Web server: nginx/1.14.2
  • Database version: 8.0.18 - MySQL Community Server - GPL
  • PHP version: 7.4.21
  • phpMyAdmin version: RELEASE_5_1_1-1058-gf0bb3c42e0

Client configuration

  • Browser: Firefox 90
  • Operating system: Linux

Additional context

Spatial functions are missing from the list of selectable functions when inserting data, may be related.

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jul 20, 2021
@williamdes williamdes added this to Needs triage in issues via automation Jul 20, 2021
@williamdes williamdes moved this from Needs triage to Reproduced in issues Jul 20, 2021
@williamdes
Copy link
Member

williamdes commented Jul 20, 2021

Hi @MoonE

Please have a look to the home page for the version because "RELEASE_5_1_1-1058-gf0bb3c42e0" does not indicate the true version you are looking at as said on #14813 (comment)

@MoonE
Copy link
Contributor Author

MoonE commented Jul 20, 2021

Isn't the last part of that string the commit hash of the version? f0bb3c42e0
What info do you need?

@williamdes
Copy link
Member

Isn't the last part of that string the commit hash of the version? f0bb3c42e0
What info do you need?

Do not worry it is okay for me, but for contributors it may be more complicated to understand this is why I advise to say the real version

@williamdes
Copy link
Member

On MariaDB 10.6 I am able to use the insert by selecting the function after the fix of #17079

INSERT INTO `gis_all` (`name`, `shape`) VALUES ('', ST_GeomFromText('POINT(0 0)',0));

@williamdes
Copy link
Member

Maybe the fix would be to select a geometry function after copying the value

@williamdes williamdes added this to the 5.1.2 milestone Aug 18, 2021
@williamdes williamdes self-assigned this Aug 18, 2021
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 18, 2021
williamdes added a commit that referenced this issue Aug 18, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants