Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

''Browse" button visible when creating a table from the database structure view #17019

Closed
MoonE opened this issue Jul 18, 2021 · 0 comments
Closed

''Browse" button visible when creating a table from the database structure view #17019

MoonE opened this issue Jul 18, 2021 · 0 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
issues
Milestone
5.1.2

Comments

@MoonE
Copy link
Contributor

MoonE commented Jul 18, 2021 •
edited by williamdes

Describe the bug

The browse button should only be displayed when an already existing table is selected.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://demo.phpmyadmin.net/master-config
  2. Select a database ('Structure' tab)
  3. In the main view go to 'Create table'
  4. enter a name and click 'Go'
  5. 'Browse' button is visible at the top, when clicked it shows an error

Expected behavior

The button should not be visible when the table does not exist.
This works when the table is created via 'New' in the navigation panel

Server configuration

  • Web server: nginx/1.14.2
  • Database version: 8.0.18 - MySQL Community Server - GPL
  • PHP version: 7.4.21
  • phpMyAdmin version: 5.2.0-dev

Client configuration

  • Browser: Firefox 90
  • Operating system: Linux
@williamdes williamdes added Bug A problem or regression with an existing feature help wanted ui Issues relating to the user interface labels Jul 20, 2021
@williamdes williamdes added this to Needs triage in issues via automation Jul 20, 2021
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Jul 20, 2021
@lrb2 lrb2 mentioned this issue Aug 9, 2021
Merged
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 9, 2021
@williamdes williamdes added this to the 5.1.2 milestone Aug 9, 2021
@williamdes williamdes self-assigned this Aug 9, 2021
@williamdes williamdes changed the title ''Browse' button visible when creating a table from the database structure view ''Browse" button visible when creating a table from the database structure view Aug 9, 2021
williamdes added a commit that referenced this issue Aug 9, 2021
@williamdes
Add a ChangeLog entry for #17019
5686b15 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Aug 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.2
Development

No branches or pull requests
2 participants
@MoonE @williamdes