Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change structure does not surface errors #17037

Closed
ChrisHSandN opened this issue Jul 26, 2021 · 1 comment
Closed

Change structure does not surface errors #17037

ChrisHSandN opened this issue Jul 26, 2021 · 1 comment
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@ChrisHSandN
Copy link

ChrisHSandN commented Jul 26, 2021

Describe the bug

If a structure change is made which causes an error, the error is never shown and PHPMyAdmin returns to the structure view as if it has worked.

To Reproduce

Steps to reproduce the behaviour:

CREATE TABLE `1_test` (
  `id` varchar(10) COLLATE utf8_unicode_ci NOT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB;

INSERT INTO `1_test` SELECT 'abc';
  1. Go to 'Structure'
  2. Click on 'Change' next to id
  3. Change Length/Values to 1 (e.g. too small to contain 'abc')
  4. Click "Save"
  5. No error is shown and VARCHAR is still length 10

Expected behaviour

Error should be shown

Screenshots

image

image

Server configuration

  • Operating system: CentOS
  • Web server: Apache/2.4.6
  • Database version: mariadb 10.4.20
  • PHP version: 7.4.21
  • phpMyAdmin version: 5.1.1-1

Client configuration

  • Browser: Chrome
  • Operating system: Windows 10

Additional context

#17016 sounds similar, but in this case I am not ticking the checkbox "Online Transaction".

Running the query produced by "Preview SQL" manaually shows the expected error:

image

@williamdes
Copy link
Member

Hi @ChrisHSandN
I can confirm that using PerconaDb 5.7
#1265 - Data truncated for column 'id' at row 1 should be displayed

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jul 26, 2021
@williamdes williamdes added this to the 5.1.2 milestone Jul 26, 2021
@williamdes williamdes added this to Needs triage in issues via automation Jul 26, 2021
@williamdes williamdes moved this from Needs triage to High priority in issues Jul 26, 2021
@williamdes williamdes self-assigned this Jul 26, 2021
williamdes added a commit that referenced this issue Jul 26, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from High priority to Closed Jul 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants