Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some archaeology to find out why there is configs about designer_coords that did disappear #17092

Closed
williamdes opened this issue Aug 27, 2021 · 2 comments
Assignees
Milestone

Comments

@williamdes
Copy link
Member

williamdes commented Aug 27, 2021

In phpMyAdmin versions before 4.3.0 alpha 1 there was a setting named
$cfg['Servers'][$i]['designer_coords']
See: https://github.com/phpmyadmin/phpmyadmin/blob/RELEASE_4_2_13_3/libraries/config.default.php#L399
See: https://github.com/phpmyadmin/phpmyadmin/blob/RELEASE_4_2_13_3/doc/config.rst

It no longer exists since #1232

The feature was first documented in fb9a3a5

@williamdes williamdes added this to the 5.1.2 milestone Aug 27, 2021
@williamdes williamdes self-assigned this Aug 27, 2021
@williamdes
Copy link
Member Author

I am adding this back to the documentation so our users can remove it from their configs and find out it does not exist anymore.

cc @MauricioFauth for #17050
cc @clementmoulin to remove it from your config (found while working on #16906)

@williamdes
Copy link
Member Author

I think the migration SQL script to 4.3 should have been adjusted, but sincerely, 7 years after, It will stay as it is.

williamdes added a commit that referenced this issue Aug 27, 2021
Ref: #1232
Fixes: #17092

Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant