The preview sql button tabindex is never refreshed

[Jir4]

Describe the bug

Adding more rows in the form on tbl_change.php didn't change the tabindex of the preview sql button. (default tabindex seems to be 2*number of column + 6 ). If you have more fields than this field, your focus will jump onto the preview button.

To Reproduce

CREATE TABLE `tabindex` ( `field1` INT NOT NULL , `field2` INT NOT NULL , `field3` INT NOT NULL ) ENGINE = InnoDB; 

Steps to reproduce the behavior:

0. Create a table with the query above
1. Go to the insert page
2. Scroll down to 'Continue insertion with'
3. Add 4 rows
4. Go to the 9th field ( last field of the 3rd row)
5. Press tab

Expected behavior

The focus should be in the first field of the 4th row

Server configuration

• Operating system: Debian 10
• Web server: Apache/2.4.38
• Database version: 10.3.29-MariaDB-0+deb10u1
• PHP version: 7.4.23
• phpMyAdmin version: 5.0.4deb2~bpo10+1

Client configuration

• Browser: Firefox 93.0b4 (64 bits)
• Operating system: macOS bêta 12.0 (21A5506j)

Additional context

An extension like this one help a lot.

The behavior can be easly fixed but i'm not aware of what it involves so i create an issue instead of a PR :

• add a control_at_footer class to the preview sql button here
• or update the rule here

[Jir4]

Any news ?

[williamdes]

Hi @Jir4

I am sorry for the time this got for you to have an answer, we will be looking in to this soon.

Maybe you could try to update to phpMyAdmin 5.1 I uploaded to Debian bullseye backports or use our Ubuntu PPA, see: Wiki for install methods on Ubuntu/Debian

[Jir4]

Hi thanks for your answer, the problem is still present, i checked the code to suggest a way to patch this in my first message.

I can still make the PR if someone can validate me my way to fix that.

[williamdes]

Hi thanks for your answer, the problem is still present, i checked the code to suggest a way to patch this in my first message.

I can still make the PR if someone can validate me my way to fix that.

Sure, feel free to create a branch from QA_5_1 branch and push your fix or the branch and make a PR for it :)
I will review it
Merci

[Jir4]

@williamdes done.