Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy to clipboard with NULL values gives terrible output #17228

Closed
williamdes opened this issue Dec 6, 2021 · 2 comments · Fixed by #17232
Closed

Copy to clipboard with NULL values gives terrible output #17228

williamdes opened this issue Dec 6, 2021 · 2 comments · Fixed by #17232
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.2

Comments

@williamdes
Copy link
Member

Describe the bug

Copy to clipboard with NULL values gives terrible output

To Reproduce

Steps to reproduce the behavior:

  1. Have NULL and other values
  2. Click on "Copy to clipboard"
  3. See horrible text output copied

Expected behavior

Understand NULL values

Server configuration

  • phpMyAdmin version: 5.1

Client configuration

  • Browser: Chrome
@williamdes williamdes added Bug A problem or regression with an existing feature good first issue labels Dec 6, 2021
@williamdes williamdes added this to the 5.1.2 milestone Dec 6, 2021
@williamdes williamdes added this to Needs triage in issues via automation Dec 6, 2021
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Dec 6, 2021
@MauricioFauth
Copy link
Member

From what I tested, the only difference is the line breaks around NULL values. Is that what you talking about?

@williamdes
Copy link
Member Author

From what I tested, the only difference is the line breaks around NULL values. Is that what you talking about?

Yes, line breaks and spaces
If you copy in vscode or Slack it's unusable

@jonahtanjz jonahtanjz mentioned this issue Dec 8, 2021
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Dec 10, 2021
@williamdes williamdes self-assigned this Dec 12, 2021
williamdes added a commit that referenced this issue Dec 12, 2021
@williamdes
Add a ChangeLog entry for #17228
9342872 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Dec 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.2
Development

Successfully merging a pull request may close this issue.

Fix #17228 - Resolve formatting of copy to clipboard with NULL values jonahtanjz/phpmyadmin
2 participants
@MauricioFauth @williamdes