Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting Database List on "Data" Column creates a PHP type error #17287

Closed
danallendotcom opened this issue Jan 10, 2022 · 6 comments
Closed

Sorting Database List on "Data" Column creates a PHP type error #17287

danallendotcom opened this issue Jan 10, 2022 · 6 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Milestone

Comments

@danallendotcom
Copy link

danallendotcom commented Jan 10, 2022

Describe the bug

Sorting on the "Data" column in the list of databases throws a bomb.

To Reproduce

Steps to reproduce the behavior:

  1. Go to home page
  2. Click on "databases" in the tabs across the top of the main pane.
  3. At the bottom of the list of databases, click "Enable Statistics," to see more columns in the list of databases.
  4. In the column labels for the list of databases, click on column names to sort by those columns
  5. Click on the "Data" column.
  6. Bomb appears

Expected behavior

The list of databases should continue being displayed, without an error message, with the databases sorted by the values in the "Data" column

Screenshots

image
image
image

If applicable, add screenshots to help explain your problem.

I do not appreciate the presumption that this is my problem. You might not be aware, peer-reviewed research has shown, there is an anti-social habit common among IT workers to presume problems are caused by anyone besides themselves or their organization. In this case, I don't know the root cause of the bomb on the data column. I am not yet able to rule out the possibility the problem is caused by an error on my part. I also am not able to rule out the possibility of the problem being part of the phpmyadmin system. For all I know, the problem could lie outside your shop and mine.

_There are few things I know for sure, but one of them is relevant here. Whoever wrote onto this form, " add screenshots to help explain your problem" did not know before I encountered the problem that it is my problem.

Learn boundaries. Learn to respect people.

Change this form to not say "explain your problem". The world will be better as a result.

Server configuration

  • Operating system: Debian GNU/Linux 11 (bullseye) and Debian GNU/Linux 10 (buster)
  • Web server: Apache/2.4.38 (Debian)
  • Database version: Ver 15.1 Distrib 10.5.12-MariaDB, for debian-linux-gnu (x86_64) using EditLine wrapper and mysql Ver 15.1 Distrib 10.3.31-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
  • PHP version: PHP Version 7.3.33
  • phpMyAdmin version: Version information: 5.1.1

Client configuration

  • Browser: Brave, Firefox
  • Operating system: MacOS

Additional context

Add any other context about the problem here.

Thank you.

@williamdes williamdes added the Bug A problem or regression with an existing feature label Feb 4, 2022
@williamdes
Copy link
Member

Hi @danallendotcom
You are not using phpMyAdmin 5.1, for two reasons: in e2eac49#diff-4a0988e36d96e1c9c66ee104d61701aa801e2079dac8cae96efd2e540f057000R901 the function was renamed and in aadb6ab I moved it in another class.

In 4.9

private static function _usortComparisonCallback($a, $b)

And so when I moved the function I added typehints and that fixed the issue you report: aadb6ab

Thank you for the feedback on the issue form.

Please check that you are up to date and that you purged opcache if you are using this php extension.

@williamdes williamdes self-assigned this Feb 4, 2022
@williamdes williamdes changed the title Sorting Database List on "Data" Column Bombs Sorting Database List on "Data" Column creates a PHP type error Feb 4, 2022
williamdes added a commit that referenced this issue Feb 4, 2022
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

I applied your feedback in 68b4e19

@danallendotcom
Copy link
Author

danallendotcom commented Feb 11, 2022

@williamdes wrote _You are not using phpMyAdmin 5.1, for two reasons: in e2eac49#diff-4a0988e36d96e1c9c66ee104d61701aa801e2079dac8cae96efd2e540f057000R901 the function was renamed and in aadb6ab I moved it in another class.

The version was 5.1.1. Please see below for an image showing the phpmyadmin version and a link to a video showing the version and bomb. If you would like to login to the installation and try it yourself, you are more than welcome. URL and login credentials provided after the video link. If there are any files you would like to examine, please do not hesitate to let me know, so I can post them here for you.

image

Video:

phpmyadminv5_1_1.mp4

The bomb is not present in 5.1.3.

@williamdes
Copy link
Member

williamdes commented Feb 11, 2022

I am very glad this is now fixed in 5.1.3

@williamdes
Copy link
Member

williamdes commented Feb 11, 2022

I am very glad this is now fixed in 5.1.3

Edit: I can reproduce this on 5.1.3 now

This config is needed: $cfg['Servers'][$i]['DisableIS'] = true;

@williamdes williamdes reopened this Feb 11, 2022
@williamdes williamdes modified the milestones: 4.9.11, 5.1.4 Feb 11, 2022
@williamdes
Copy link
Member

I am very glad this is now fixed in 5.1.3

Edit: I can reproduce this on 5.1.3 now

This config is needed: $cfg['Servers'][$i]['DisableIS'] = true;

Seems it's a bit intermittent on my end but tests will cover this.
Can you delete my username @danallendotcom ?

williamdes added a commit that referenced this issue Feb 11, 2022
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 12, 2022
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants