Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of email-adresses or links from ods results in empty contents #17298

Closed
mokraemer opened this issue Jan 17, 2022 · 1 comment
Closed

Import of email-adresses or links from ods results in empty contents #17298

mokraemer opened this issue Jan 17, 2022 · 1 comment
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Milestone
5.1.3

Comments

@mokraemer
Copy link
Contributor

Describe the bug

importing mail-adresses from ods fails.

To Reproduce

the mail adresses are formated in the ods as follows:
<text:a xlink:href="mailto:abc@def.ghi" xlink:type="simple">
abc@def.ghi</text:a>

Expected behavior

a text col containing the value abc@def.ghi

Screenshots

it is imported as empty column

Server configuration

php 8.0.14
phpMyAdmin 5.1.1
@williamdes williamdes added the Bug A problem or regression with an existing feature label Feb 6, 2022
@williamdes williamdes added this to the 5.1.3 milestone Feb 6, 2022
@williamdes
Copy link
Member

williamdes commented Feb 6, 2022 •
edited

Hi @mokraemer

I did start to fix this bug, could you try this on your side ?

Patch: cba5300

@williamdes williamdes mentioned this issue Feb 6, 2022
Closed
@williamdes williamdes changed the title Import of email-adresses from ods fails Import of email-adresses from ods results in empty contents Feb 6, 2022
@williamdes williamdes self-assigned this Feb 6, 2022
williamdes added a commit that referenced this issue Feb 6, 2022
@williamdes
Ref #17298 - pretty format the test file before changing it
fa546b1 
I need to see the diff to fix some bugs I did discover in the next version of this document

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 6, 2022
@williamdes
Ref #17298, #17344 - Update the test data to include more cases
82ed483 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 6, 2022
@williamdes
Ref #17298, #17344 - fix ODS import tests
4e68f54 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 6, 2022
@williamdes
Ref #17298, #17344 - update the phpstan and psalm baselines
a944c04 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes changed the title Import of email-adresses from ods results in empty contents Import of email-adresses or links from ods results in empty contents Feb 6, 2022
williamdes added a commit that referenced this issue Feb 6, 2022
@williamdes
Add ChangeLog entries for #17298 and #17344
03bb85f 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
None yet
Milestone
5.1.3
Development

No branches or pull requests
2 participants
@mokraemer @williamdes