Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation panel - table list is broken (5.1.2) #17308

Closed
svivian opened this issue Jan 22, 2022 · 3 comments · Fixed by #17324
Closed

Navigation panel - table list is broken (5.1.2) #17308

svivian opened this issue Jan 22, 2022 · 3 comments · Fixed by #17324
Assignees
@MauricioFauth
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone
5.1.3

Comments

@svivian
Copy link
Contributor

svivian commented Jan 22, 2022 •
edited

Describe the bug

The navigation panel in the latest version (5.1.2) is very broken. Using the page selector replaces the table list with a database list.

To Reproduce

  1. Open PMA.
  2. Click a table name to see the list of tables.
  3. Click the > button to move to the next page of tables.

Instead of showing the next page, it shows the list of databases instead. Example from the demo server:

Screenshot 2022-01-22 at 13 13 12

Screenshot 2022-01-22 at 13 13 27

After that PMA is full of errors, for example clicking another database in the outer list says "No databases selected". Or sometimes the tables get put in a "Views" subcategory even if they're not views.

PMA 5.1.2, PHP 7.4, MySQL 5.7, latest Chrome. Also tested on demo server.
@williamdes williamdes added this to the 5.1.3 milestone Jan 22, 2022
@spyjo
Copy link

spyjo commented Jan 24, 2022

I confirm this bug after upgrading from 5.1.1 to 5.1.2
Selecting an other number with the select form is still functioning, but not the arrows.

@williamdes williamdes added Bug A problem or regression with an existing feature help wanted labels Jan 24, 2022
@ibennetch
Copy link
Member

Git bisect tells me that 4fd7aa7 is the first bad commit, "Use POST for Navigation's aPath and vPath."

This was referenced Jan 27, 2022
Merged
Merged
@MauricioFauth MauricioFauth added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete and removed help wanted labels Jan 27, 2022
@MauricioFauth
Copy link
Member

@ibennetch I opened two PRs. A fix for 4.9.x and another for 5.1.x.

@MauricioFauth MauricioFauth self-assigned this Jan 27, 2022
@MauricioFauth MauricioFauth linked a pull request Jan 27, 2022 that will close this issue
[5.1] Fix broken pagination links in the navigation sidebar #17324
Merged
MauricioFauth added a commit that referenced this issue Jan 28, 2022
@MauricioFauth
Add ChangeLog entry for #17308
5c5f59d 
- Fix broken pagination links in the navigation sidebar

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth added a commit that referenced this issue Jan 28, 2022
@MauricioFauth
Add ChangeLog entry for #17308
362deb2 
- Fix broken pagination links in the navigation sidebar

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@williamdes williamdes mentioned this issue Feb 6, 2022
Closed
@williamdes williamdes mentioned this issue Apr 6, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MauricioFauth MauricioFauth

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Milestone
5.1.3
Development

Successfully merging a pull request may close this issue.

[5.1] Fix broken pagination links in the navigation sidebar MauricioFauth/phpmyadmin
5 participants
@MauricioFauth @svivian @ibennetch @spyjo @williamdes