Fatal error: Unsupported operand types in Results.php

[michael-gilch]

Describe the bug

SHOW PROCESSLIST; throws fatal error in latest version (5.1.2):

PHP Fatal error: Uncaught TypeError: Unsupported operand types: null + array in .../libraries/classes/Display/Results.php:2589

This seems to be caused by initializing $editCopyUrlParams = null; and later trying to append more elements without assigning a value:

Results.php, Line 2589:

'params' => $editCopyUrlParams + ['default_action' => 'update'],

To Reproduce

Steps to reproduce the behavior:

1. Open PMAs SQL Editor.
2. Type in "SHOW PROCESSLIST;"
3. Click OK to execute the query

An internal server error (500) is shown

Expected behavior

Showing the process list's result set

Server configuration

• Operating system: Debian
• Web server: Apache
• Database version: 5.7
• PHP version: >=7.4
• phpMyAdmin version: 5.1.2

Client configuration

• Browser: Firefox
• Operating system: Ubuntu

Additional context

For a quick fix you can check the value before joining arrays in every 'params' section:

'params' => ($editCopyUrlParams == null) ? ['default_action' => 'update'] : $editCopyUrlParams + ['default_action' => 'update'],

[williamdes]

Hi @michael-gilch
Thank you for the issue, I can confirm it on our demo server and in our static analysis tool reports.