Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The menu to toggle column visibility is half hidden #17335

Closed
xavier-dev opened this issue Feb 3, 2022 · 1 comment · Fixed by #17337
Closed

The menu to toggle column visibility is half hidden #17335

xavier-dev opened this issue Feb 3, 2022 · 1 comment · Fixed by #17337
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Milestone

Comments

@xavier-dev
Copy link
Contributor

xavier-dev commented Feb 3, 2022

Describe the bug

When browsing a table, I can click a drop-down arrow to toggle the columns visibility. It opens a menu showing one line per column with a checkbox. When at least one of the column has a too long name or a too long comment, the menu is too large to fit on the screen and the left part is hidden. As a result, it's not possible to click on the checkboxes

To Reproduce

Steps to reproduce the behavior:

  1. Create a table with long column names or comments
CREATE TABLE `test` (
  `id` int NOT NULL,
  `column_with_a_very_very_long_name` int NOT NULL,
  `col2` int NOT NULL COMMENT 'This columns has a very long comment.'
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
ALTER TABLE `test` ADD PRIMARY KEY (`id`);
INSERT INTO `test` (`id`, `column_with_a_very_very_long_name`, `col2`) VALUES (1, 1, 1), (2, 2, 2);
  1. Open the "Browse" tab for this table.
  2. Click on the drop-down arrow to toggle the columns visibility

Expected behavior

The menu to toggle the columns visibility should be fully visible.

Screenshots

image

Server configuration

  • Database version: MySQL 8.0.27
  • PHP version: 8.1.2
  • phpMyAdmin version: 5.1.1

Client configuration

  • Browser: Chrome 97.0.4692.99
  • Operating system: Windows
xavier-dev added a commit to xavier-dev/phpmyadmin that referenced this issue Feb 3, 2022
…dden

Signed-off-by: Xavier Rogé <xavier@numista.com>
xavier-dev added a commit to xavier-dev/phpmyadmin that referenced this issue Feb 3, 2022
…dden

Signed-off-by: Xavier Rogé <xavier@numista.com>
@xavier-dev
Copy link
Contributor Author

I submitted a fix. This is my first contribution: please let me know if anything needs to be adjusted.

image

@williamdes williamdes added this to the 5.1.3 milestone Feb 3, 2022
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Feb 3, 2022
@ibennetch ibennetch modified the milestones: 5.1.3, 5.1.4 Feb 11, 2022
MauricioFauth added a commit that referenced this issue Apr 22, 2022
Fix #17335: The menu to toggle column visibility is half hidden
@MauricioFauth MauricioFauth self-assigned this Apr 22, 2022
@williamdes williamdes added this to Needs triage in issues via automation Apr 22, 2022
@williamdes williamdes moved this from Needs triage to Closed in issues Apr 22, 2022
MauricioFauth added a commit to MauricioFauth/phpmyadmin that referenced this issue Apr 26, 2022
…yadmin#17445

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

4 participants