Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[import ODS] Fatal error: Uncaught TypeError: strcmp(): Argument #2 ($string2) must be of type string, float given #17344

Closed
williamdes opened this issue Feb 6, 2022 · 0 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone

Comments

@williamdes
Copy link
Member

Describe the bug

While working on #17298 I created a file that throws a bug

Fatal error: Uncaught TypeError: strcmp(): Argument #2 ($string2) must be of type string, float given in
libraries/classes/Plugins/Import/ImportOds.php:388 Stack trace: #0
libraries/classes/Plugins/Import/ImportOds.php(388): strcmp('NULL', 0.05) #1
libraries/classes/Plugins/Import/ImportOds.php(432): PhpMyAdmin\Plugins\Import\ImportOds->iterateOverRows(Object(SimpleXMLElement), false, Array, Array, 1, 1, Array) #2
libraries/classes/Plugins/Import/ImportOds.php(178): PhpMyAdmin\Plugins\Import\ImportOds->iterateOverTables(Object(SimpleXMLElement)) #3
libraries/classes/Controllers/ImportController.php(634): PhpMyAdmin\Plugins\Import\ImportOds->doImport(Object(PhpMyAdmin\File), Array) #4
libraries/classes/Routing.php(187): PhpMyAdmin\Controllers\ImportController->index(Array) #5
index.php(18): PhpMyAdmin\Routing::callControllerForRoute('/import', Object(FastRoute\Dispatcher\GroupCountBased), Object(Symfony\Component\DependencyInjection\ContainerBuilder)) #6 {main} thrown in
libraries/classes/Plugins/Import/ImportOds.php on line 388

To Reproduce

Steps to reproduce the behavior:

  1. Import this file into a DB: import-email-test.ods

Expected behavior

No error

Server configuration

  • phpMyAdmin version: 5.1.3-dev

Add any other context about the problem here.

@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Feb 6, 2022
@williamdes williamdes added this to the 5.1.3 milestone Feb 6, 2022
@williamdes williamdes self-assigned this Feb 6, 2022
williamdes added a commit that referenced this issue Feb 6, 2022
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 6, 2022
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 6, 2022
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 6, 2022
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Development

No branches or pull requests

1 participant