Broken configuration file error display is broken

[williamdes]

Describe the bug

Due to c04f85f

To Reproduce

Make a config file with a php syntax mistake in it

Expected behavior

Screenshots

Do not try to fix errors one by one from the screenshot below, it is pointless as you will end up rendering ErrorHandler::handleException and a white non user friendly page

Server configuration

• phpMyAdmin version: 5.2

Additional context

Preferred patch

diff --git a/libraries/classes/Common.php b/libraries/classes/Common.php
index 635dc69c33..3a57201dd5 100644
--- a/libraries/classes/Common.php
+++ b/libraries/classes/Common.php
@@ -92,8 +92,6 @@ public static function run(): void
 
         $containerBuilder = Core::getContainerBuilder();
 
-        /** @var ErrorHandler $errorHandler */
-        $errorHandler = $containerBuilder->get('error_handler');
 
         self::checkRequiredPhpExtensions();
         self::configurePhpSettings();
@@ -114,6 +112,9 @@ public static function run(): void
          */
         $config = $containerBuilder->get('config');
 
+        /** @var ErrorHandler $errorHandler */
+        $errorHandler = $containerBuilder->get('error_handler');
+
         /**
          * include session handling after the globals, to prevent overwriting
          */

Alternative patch

diff --git a/libraries/classes/ErrorHandler.php b/libraries/classes/ErrorHandler.php
index 1e114ccc2f..f89cc3f03b 100644
--- a/libraries/classes/ErrorHandler.php
+++ b/libraries/classes/ErrorHandler.php
@@ -64,6 +64,8 @@ class ErrorHandler
 
     public function __construct()
     {
+        global $isConfigLoading;
+
         /**
          * Do not set ourselves as error handler in case of testsuite.
          *
@@ -71,7 +73,9 @@ public function __construct()
          * rely on PHPUnit doing it's own error handling which we break here.
          */
         if (! defined('TESTSUITE')) {
-            set_exception_handler([$this, 'handleException']);
+            if ($isConfigLoading) {
+                set_exception_handler([$this, 'handleException']);
+            }
             set_error_handler([$this, 'handleError']);
         }
 

[williamdes]

@MauricioFauth you did the fix I mentioned, what is the best patch ?