remove_msie9 (fix_11987) #11995
Merged
remove_msie9 (fix_11987) #11995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poush
force-pushed
the
remove_msie9
branch
4 times, most recently
from
5679060
to
5fa11a3
Compare
|
I believe that by the DCO, we need to require a full name (unless Piyush is your complete legal name). Aside from that, this looks good to me, although I don't actually have IE anymore to test some aspects of it. |
|
Can anyone please help me understand 'Failure' on https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/110457341 at line |
|
@ibennetch I will ensure to keep my full name in my commits. I will also update this one on next commit when errors are removed |
poush
force-pushed
the
remove_msie9
branch
3 times, most recently
from
7309572
to
388f273
Compare
Signed-off-by: Piyush Agrawal <poush12@gmail.com>
|
Looks like the tests are passing now, thanks. |
|
Thanks, I've merged your changes. But for next time, please use more descriptive commit messages... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piyush poush12@gmail.com