Fixes #11983 pop out SQL window #12328

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Achilles-96
Contributor
Achilles-96 commented Jun 17, 2016 edited

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on its own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Signed-off-by: Raghuram Vadapalli raghuram.vadapalli@research.iiit.ac.in

@Achilles-96
Contributor

Sorry for the delay.
@nijel, I am showing the results in parent window as you said. Please review.

@codecov-io
codecov-io commented Jun 17, 2016 edited

Current coverage is 52.66%

Merging #12328 into master will decrease coverage by 0.01%

@@             master     #12328   diff @@
==========================================
  Files           470        471     +1   
  Lines         79530      79555    +25   
  Methods        2106       2106          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          41901      41901          
- Misses        37629      37654    +25   
  Partials          0          0          

Powered by Codecov. Last updated by aa3c345...0ca377f

@Achilles-96 Achilles-96 Fixes #11983 pop out SQL window
Signed-off-by: Raghuram Vadapalli <raghuram.vadapalli@research.iiit.ac.in>
0ca377f
@nijel
Member
nijel commented Jul 29, 2016

There are still few bugs:

  • once you close the query window, the link no longer opens new window, but rather replaces phpMyAdmin main window
  • the opened window is still badly sized (at least the submit button should be visible, but ideally it would scale the textarea to fit into window making the controls visible all the time), see screenshot below
  • there is no synchronization with main window, so there is really no way to change database used in querywindow, ideally it would change database in sync with main window

snimek z 2016-07-29 13-41-23

@nijel nijel self-assigned this Jul 29, 2016
@nijel
Member
nijel commented Jan 20, 2017

Closing this as it's not ready for merge at this state and hasn't received updates for months.

@nijel nijel closed this Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment