Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12327: Show as PHP No longer works #12596

Merged
merged 2 commits into from Oct 3, 2016
Merged

Conversation

@devenbansod
Copy link
Member

devenbansod commented Sep 27, 2016

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Fix output of show_as_php. Don't show the links that are not required
or that may not work as expected

Fix #12327

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

devenbansod added 2 commits Sep 27, 2016
Fix output of show_as_php. Don't show the links that are not required
or that may not work as expected

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 27, 2016

Current coverage is 50.20% (diff: 53.84%)

Merging #12596 into QA_4_6 will increase coverage by <.01%

@@             QA_4_6     #12596   diff @@
==========================================
  Files           485        485          
  Lines         81243      81249     +6   
  Methods        2126       2126          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          40786      40791     +5   
- Misses        40457      40458     +1   
  Partials          0          0          

Powered by Codecov. Last update 5511b39...9bd75db

@nijel nijel self-assigned this Oct 3, 2016
@nijel nijel merged commit 9bd75db into phpmyadmin:QA_4_6 Oct 3, 2016
4 checks passed
4 checks passed
codecov/patch 53.84% of diff hit (target 50.20%)
Details
codecov/project 50.20% (+<.01%) compared to 5511b39
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 49.796%
Details
@nijel

This comment has been minimized.

Copy link
Member

nijel commented Oct 3, 2016

There was some non trivial forward porting in libraries/Util.php to master, it would be great if you could review these....

@devenbansod devenbansod deleted the devenbansod:fix_12327 branch Oct 3, 2016
@devenbansod

This comment has been minimized.

Copy link
Member Author

devenbansod commented Oct 3, 2016

I just reviewed fc5bb4a .
It looks fine! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.