Do not delete session on fatal error #12807

Merged
merged 1 commit into from Dec 19, 2016

Projects

None yet

2 participants

@nijel
Member
nijel commented Dec 13, 2016

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

I see no reason why this should be done, the fatal error is used
in following cases:

  • Very early when there is no session (eg. missing extension)
  • Invalid value for parameters
  • Invalid invocation like too big request

In neither case session removal will do any good.

Signed-off-by: Michal Čihař michal@cihar.com

@nijel nijel changed the base branch to phpmyadmin:QA_4_6 from phpmyadmin:master Dec 13, 2016
@codecov-io
codecov-io commented Dec 13, 2016 edited

Current coverage is 50.15% (diff: 100%)

Merging #12807 into QA_4_6 will decrease coverage by <.01%

@@             QA_4_6     #12807   diff @@
==========================================
  Files           485        485          
  Lines         81403      81397     -6   
  Methods        2133       2133          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          40829      40825     -4   
+ Misses        40574      40572     -2   
  Partials          0          0          

Powered by Codecov. Last update a1fa82f...73499a5

@nijel nijel Do not delete session on fatal error
I see no reason why this should be done, the fatal error is used
in following cases:

* Very early when there is no session (eg. missing extension)
* Invalid value for parameters
* Invalid invocation like too big request

In neither case session removal will do any good.

Signed-off-by: Michal Čihař <michal@cihar.com>
73499a5
@nijel nijel self-assigned this Dec 19, 2016
@nijel nijel added this to the 4.6.6 milestone Dec 19, 2016
@nijel nijel merged commit 2557709 into phpmyadmin:QA_4_6 Dec 19, 2016

4 checks passed

codecov/patch 100% of diff hit (target 50.15%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +49.84% compared to a1fa82f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 49.744%
Details
@nijel nijel deleted the nijel:cookie-fatal branch Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment