Add source release, strip current ones #12836

Merged
merged 6 commits into from Jan 25, 2017

Projects

None yet

3 participants

@nijel
Member
nijel commented Dec 19, 2016 edited

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

See #12348 for discussion which lead to writing this code.

This add source release and removes many files from the standard releases, the outcome is:

  • smaller default download size (around 2 MB saved on every single file)
  • less chance for exploits for normal users as they don't get testsuite (they don't need)
  • there is one more download kit including sources, it is quite big as it includes po files we did not ship before at all (strictly speaking this violates GPL)
  • to reduce number of download options, I've disabled 7z and tar.bz2 compressions
nijel added some commits Dec 19, 2016
@nijel nijel Remove not used option
We use 7z for creating zips for ages, this code was not used for years.

Signed-off-by: Michal Čihař <michal@cihar.com>
401ecbd
@nijel nijel Remove .tar.bz2 release
It's almost not downloaded and people usually can choose xz instead
which does compress better.

See phpmyadmin#12348

Signed-off-by: Michal Čihař <michal@cihar.com>
b6b3adf
@nijel nijel Remove 7z download option
It does compress worse than tar.xz and experienced users won't have
problems using either of these.

See phpmyadmin#12348

Signed-off-by: Michal Čihař <michal@cihar.com>
9dc5ccc
@nijel nijel Add source release support
See #12348

Signed-off-by: Michal Čihař <michal@cihar.com>
0e5cf50
@nijel nijel Remove codecov.yml on release
Signed-off-by: Michal Čihař <michal@cihar.com>
b567783
@nijel nijel self-assigned this Dec 19, 2016
@nijel nijel Add source to upload release script
Signed-off-by: Michal Čihař <michal@cihar.com>
b0eb828
@codecov-io
codecov-io commented Dec 19, 2016 edited

Current coverage is 54.24% (diff: 100%)

Merging #12836 into master will not change coverage

@@             master     #12836   diff @@
==========================================
  Files           466        466          
  Lines         69638      69638          
  Methods        2122       2122          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          37773      37773          
  Misses        31865      31865          
  Partials          0          0          

Powered by Codecov. Last update 0292859...b0eb828

@nijel nijel changed the title from Source release [WIP] to Source release Dec 21, 2016
@nijel nijel changed the title from Source release to Add source release, strip current ones Dec 21, 2016
@nijel
Member
nijel commented Dec 21, 2016

I think this is ready for review, comments welcome from all @phpmyadmin/developers :-)

@ibennetch
Contributor

Looks good to me.

@nijel
Member
nijel commented Jan 2, 2017

Probably this should be merged after 4.6.6 is out to make the change live for 4.7.0....

@nijel
Member
nijel commented Jan 21, 2017

@ibennetch I think it would be optimal to merge this after 4.6.6 (so that it's release is unaffected), but prior to 4.7.0-beta1 (so that it gets the changes and follows new structure).

@ibennetch
Contributor

Thanks for stating that, I was also considering that such an idea was probably the best way to handle it.

@nijel nijel added this to the 4.7.0 milestone Jan 25, 2017
@nijel nijel merged commit aa1c65a into phpmyadmin:master Jan 25, 2017

4 checks passed

Scrutinizer No new issues
Details
codecov/patch Coverage not affected when comparing 0292859...b0eb828
Details
codecov/project 54.24% (+0.00%) compared to 0292859
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel nijel deleted the nijel:source-release branch Jan 25, 2017
@ibennetch
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment