Filtering tables on table listing of particular database #12838

Merged
merged 5 commits into from Dec 21, 2016

Projects

None yet

4 participants

@yunusyurdakul
Contributor
yunusyurdakul commented Dec 19, 2016 edited

Feature: #12069: Filtering tables on table listing of particular database.
Signed-off-by: Yunus Çağrı Yurdakul ycagriyurdakul@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@yunusyurdakul yunusyurdakul Feature: #12069: Filtering tables on table listing of particular data…
…base.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
ec4ef65
@phpmyadmin-bot

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/db_structure.js

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/db_structure.js

@codecov-io
codecov-io commented Dec 19, 2016 edited

Current coverage is 54.27% (diff: 100%)

Merging #12838 into master will increase coverage by 0.02%

@@             master     #12838   diff @@
==========================================
  Files           466        466          
  Lines         69633      69636     +3   
  Methods        2125       2127     +2   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          37777      37797    +20   
+ Misses        31856      31839    -17   
  Partials          0          0          

Powered by Codecov. Last update 5cbcb20...041cd61

@yunusyurdakul yunusyurdakul Feature: #12069: Filtering tables on table listing of particular data…
…base.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
b19085b
@yunusyurdakul yunusyurdakul reopened this Dec 19, 2016
@yunusyurdakul yunusyurdakul changed the title from Feature: #12069: Filtering tables on table listing of particular database to Filtering tables on table listing of particular database Dec 19, 2016
@@ -12,7 +12,8 @@ if ($GLOBALS['cfg']['NumFavoriteTables'] > 0) {
?>
<form method="post" action="db_structure.php" name="tablesForm" id="tablesForm">
<?= PMA\libraries\URL::getHiddenInputs($db); ?>
-<table class="data">
+<input type="text" id="tableSearch" onkeyup="PMA_searchTables()" placeholder="Search for tables..">
@nijel
nijel Dec 20, 2016 Member

Please do not use inline javascript, bind the event in db_structure.js, see #12782.

js/db_structure.js
+ table = $("#structureTable")[0];
+ tr = table.getElementsByTagName("tr");
+
+ for (i = 0; i < tr.length; i++) {
@nijel
nijel Dec 20, 2016 Member

Would not be better to use .each?

@nijel nijel self-assigned this Dec 20, 2016
@yunusyurdakul yunusyurdakul Inline javascript codes are removed. Each is used for table search
Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
f256391
@phpmyadmin-bot

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/db_structure.js

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/db_structure.js

@yunusyurdakul yunusyurdakul Update db_structure.js
9aaf312
@phpmyadmin-bot

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@yunusyurdakul yunusyurdakul Tab spaces are removed.
Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>
041cd61
@nijel nijel merged commit 041cd61 into phpmyadmin:master Dec 21, 2016

4 checks passed

Scrutinizer No new issues
Details
codecov/patch Coverage not affected when comparing 5cbcb20...041cd61
Details
codecov/project 54.27% (+0.02%) compared to 5cbcb20
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel nijel added a commit that referenced this pull request Dec 21, 2016
@nijel nijel Unbind event on page unload
Issue #12838, #12069

Signed-off-by: Michal Čihař <michal@cihar.com>
00b7183
@nijel nijel added a commit that referenced this pull request Dec 21, 2016
@nijel nijel Use existing filtering template for table filtering
Issue #12838, #12069

Signed-off-by: Michal Čihař <michal@cihar.com>
6a84202
@nijel nijel added a commit that referenced this pull request Dec 21, 2016
@nijel nijel Changelog for issues #12838 and #12069
Signed-off-by: Michal Čihař <michal@cihar.com>
c4fcd6c
@nijel
Member
nijel commented Dec 21, 2016

Merged, thanks for your contribution!

However I've made two minor adjustments to your code:

  • 6a84202 Use existing filtering template for table filtering
  • 00b7183 Unbind event on page unload
@ragnerok ragnerok added a commit to ragnerok/phpmyadmin that referenced this pull request Dec 21, 2016
@ragnerok ragnerok Update from original (#2)
* Do not delete session on fatal error

I see no reason why this should be done, the fatal error is used
in following cases:

* Very early when there is no session (eg. missing extension)
* Invalid value for parameters
* Invalid invocation like too big request

In neither case session removal will do any good.

Signed-off-by: Michal Čihař <michal@cihar.com>

* Do not use control link when working with stored procedures

Fixed stored procedure execution.

Fixes #12813

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix early fatal errors

We can not rely on whole stack being ready.

Fixes #12810

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix display of custom header and footer in certain edge cases.
Issues #12801 and #12802

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Translated using Weblate (Dutch)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (Dutch)

Currently translated at 100.0% (3239 of 3239 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3239 of 3239 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* MySQL allows precision to be specified for DATETIME, TIME type fields too

Fix #12814

Ref : http://dev.mysql.com/doc/refman/5.7/en/fractional-seconds.html

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* ChangeLog for #12814

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* Share code for cascading ajax flag

Signed-off-by: Michal Čihař <michal@cihar.com>

* Get response instance just once

Signed-off-by: Michal Čihař <michal@cihar.com>

* Register shutdown directly on singleton instance

This avoids additional call in the shutdown handler.

Signed-off-by: Michal Čihař <michal@cihar.com>

* Simplify checking for ajax request

Signed-off-by: Michal Čihař <michal@cihar.com>

* Include token in all filter requests

Fixes #12786

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix documentation markup

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Hints about using Composer for library dependencies

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Use documentation link instead of wiki for Composer details

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Uncomment mistakenly commented Selenium testing setting

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* Translated using Weblate (Spanish)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (Spanish)

Currently translated at 99.8% (3234 of 3239 strings)

[CI skip]

* Remove .htaccess from tests

Issue #12348

Signed-off-by: Michal Čihař <michal@cihar.com>

* Add source release support

See #12348

Signed-off-by: Michal Čihař <michal@cihar.com>

* Share code for rendering custom header and footer

Fixes #12802

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix empty password login for http authetication

Fixes #12828

Signed-off-by: Michal Čihař <michal@cihar.com>

* Honor user configured connection collation

* the user set collation is now honored
* default value has been changed to utf8mb4
* it is downgraded to utf8 if server does not support it

Fixes #12826

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix HTTP auth test expectations

Signed-off-by: Michal Čihař <michal@cihar.com>

* Remove default value for js parameter

The null is there implicitely anyway.

Fixes #12829

Signed-off-by: Michal Čihař <michal@cihar.com>

* Add some missing html encoding

Issue #12804

Signed-off-by: Michal Čihař <michal@cihar.com>

* Feature: #12069: Filtering tables on table listing of particular database.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Feature: #12069: Filtering tables on table listing of particular database.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Determine whether to use openssl just once

Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Correctly report OpenSSL errors from cookie encryption

Without calling openssl_error_string() we pollute openssl global state
and some other library might report this as failure (eg. mysqlnd driver
when connecting to SSL enabled server).

Fixes #12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use same encryption key with openssl and phpseclib

Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Test both with and without phpseclib

This ensures we generate compatible data in both cases.

Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use Header class for headers manipulation

* Added mocking of response object
* Rectified mistake of calling method once
* implemented mock properly
* replaced header with response header 

Issue #12079

Signed-off-by: Osaid osaid.nasir@gmail.com

* Inline javascript codes are removed. Each is used for table search

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Update db_structure.js

* Tab spaces are removed.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Unbind event on page unload

Issue #12838, #12069

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use existing filtering template for table filtering

Issue #12838, #12069

Signed-off-by: Michal Čihař <michal@cihar.com>

* Changelog for issues #12838 and #12069

Signed-off-by: Michal Čihař <michal@cihar.com>
a88ed64
@nijel nijel added this to the 4.7.0 milestone Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment