Fix bug #4459 #1287

Merged
merged 3 commits into from Jul 15, 2014

Conversation

Projects
None yet
5 participants
@Tithugues
Contributor

Tithugues commented Jul 15, 2014

Since 4.X, there is a little bug when trying to click on a DB name expanded in the navigation tree.
To easily reproduce it, create a DB named "a". With the bug it's quite impossible to click on it when it's expanded. With the fix, it should be ok.

Tithugues added some commits Jul 15, 2014

Fix bug #4459: first char of expanded DB could be not clickable.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
Update ChangeLog with #4459.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
@ibennetch

View changes

ChangeLog
@@ -12,6 +12,7 @@ phpMyAdmin - ChangeLog
- bug #4440 Javascript error when renaming table
- bug #4483 'New window' link (selflink) disappears, causing Javascript error
- bug #4489 Incorrect detection of privileges for routine creation
+- bug #4459 First database in navigation bar isn't clickable when expanded

This comment has been minimized.

Show comment Hide comment
@ibennetch

ibennetch Jul 15, 2014

Contributor

I suggest using "First few characters of database name aren't clickable when expanded" here, unless you can think of something better. I've also updated the title of the bug in the tracker.

@ibennetch

ibennetch Jul 15, 2014

Contributor

I suggest using "First few characters of database name aren't clickable when expanded" here, unless you can think of something better. I've also updated the title of the bug in the tracker.

@ibennetch

This comment has been minimized.

Show comment Hide comment
@ibennetch

ibennetch Jul 15, 2014

Contributor

I confirm this works for me. Notice the comment I made in-line. Thanks!

Contributor

ibennetch commented Jul 15, 2014

I confirm this works for me. Notice the comment I made in-line. Thanks!

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Jul 15, 2014

Coverage Status

Coverage increased (+0.0%) when pulling 9d3757c on Tithugues:b4459_42 into fe160ae on phpmyadmin:QA_4_2.

Coverage Status

Coverage increased (+0.0%) when pulling 9d3757c on Tithugues:b4459_42 into fe160ae on phpmyadmin:QA_4_2.

Update ChangeLog for #4459.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>

Tithugues added a commit that referenced this pull request Jul 15, 2014

Merge pull request #1287 from Tithugues/b4459_42
Fix bug #4459: First few characters of database name aren't clickable when expanded

@Tithugues Tithugues merged commit 83b1351 into phpmyadmin:QA_4_2 Jul 15, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@Tithugues Tithugues deleted the Tithugues:b4459_42 branch Jul 15, 2014

@scrutinizer-notifier

This comment has been minimized.

Show comment Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 15, 2014

The inspection completed: No new issues

The inspection completed: No new issues

@D-storm

This comment has been minimized.

Show comment Hide comment
@D-storm

D-storm Jul 17, 2014

Contributor

Hi @Tithugues ,
After this fix, I see a problem with Recent & Favorites drop list which is just above navigation tree. The items in Recent & Favorites list are getting overlapped with navigation tree items.
Thanks.

Contributor

D-storm commented Jul 17, 2014

Hi @Tithugues ,
After this fix, I see a problem with Recent & Favorites drop list which is just above navigation tree. The items in Recent & Favorites list are getting overlapped with navigation tree items.
Thanks.

@Tithugues

This comment has been minimized.

Show comment Hide comment
@Tithugues

Tithugues Jul 17, 2014

Contributor

Hi @D-storm ,
Thanks, I didn't see this.
I created a new PR: #1290 Can you confirm this is ok too for you? Let's continue in this new PR.
Thanks.

Contributor

Tithugues commented Jul 17, 2014

Hi @D-storm ,
Thanks, I didn't see this.
I created a new PR: #1290 Can you confirm this is ok too for you? Let's continue in this new PR.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment