Add margin to the "add new column" text in central columns page #12896

Merged
merged 1 commit into from Jan 18, 2017

Projects

None yet

3 participants

@MightyCupcakes
Contributor

Closes #12834

Hello, first time contributor. This PR will add a small top margin to the "add new column" text found in the central columns page. This is done by adding an existing topmargin css class found in existing css files. This eliminates the need to modify any CSS files in this PR while achieving the desired effect.

Before:

before_changes

After:

after_changes

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@MightyCupcakes MightyCupcakes Add margin to the "add new column" text in central columns page
This is done by adding the existing top margin class found in existing css files
therefore does not require any changes to the css files

Signed-off-by: Jeremy G <gohydj2003@gmail.com>
3759b6d
@codecov-io
codecov-io commented Jan 15, 2017 edited

Current coverage is 54.21% (diff: 100%)

Merging #12896 into master will not change coverage

@@             master     #12896   diff @@
==========================================
  Files           465        465          
  Lines         69647      69647          
  Methods        2128       2128          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          37758      37758          
  Misses        31889      31889          
  Partials          0          0          

Powered by Codecov. Last update b40e9c1...3759b6d

@nijel nijel self-assigned this Jan 18, 2017
@nijel nijel added this to the 4.7.0 milestone Jan 18, 2017
@nijel nijel merged commit bf3ba05 into phpmyadmin:master Jan 18, 2017

4 checks passed

Scrutinizer No new issues
Details
codecov/patch Coverage not affected when comparing b40e9c1...3759b6d
Details
codecov/project 54.21% (+0.00%) compared to b40e9c1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel
Member
nijel commented Jan 18, 2017

Merged, thanks for your contribution!

@nijel nijel added a commit that referenced this pull request Jan 18, 2017
@nijel nijel Changelog entry for #12834 and #12896
Signed-off-by: Michal Čihař <michal@cihar.com>
09d69e9
@MightyCupcakes MightyCupcakes deleted the MightyCupcakes:12834-central-column branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment