Update DBIMysqli.php #12898

wants to merge 1 commit into


None yet

3 participants

aliber4079 commented Jan 15, 2017 edited

I think u forgot to put $client_flags

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@aliber4079 aliber4079 Update DBIMysqli.php
I think u forgot to put $client_flags

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@nijel nijel self-assigned this Jan 18, 2017
@nijel nijel added a commit that referenced this pull request Jan 18, 2017
@nijel nijel Simplify mysqli database connection
- there is no need for _realConnect here as we call just one
  function in all cases (compared to mysql) backend
- properly pass connection flags (see #12898)

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel commented Jan 18, 2017

Thanks for pointing out! However when looking at the code, it's simply unnecessary complex, I've done bigger cleanup in eafd5a5.

@nijel nijel closed this Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment