Remove dead code and strings relating to xls/xlsx import and export. #12902

Merged
merged 1 commit into from Jan 18, 2017

Projects

None yet

3 participants

@ibennetch
Contributor

This code was removed in 3.4.5.0 but some strings and tests remained.

Fixes #12742

Signed-off-by: Isaac Bennetch bennetch@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@ibennetch ibennetch Remove dead code and strings relating to xls/xlsx import and export.
This code was removed in 3.4.5.0 but some strings and tests remained.

Fixes #12742

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
583e5e6
@ibennetch
Contributor
ibennetch commented Jan 18, 2017 edited

This touches some fragile areas, so a second opinion is appreciated.

@codecov-io

Current coverage is 54.18% (diff: 33.33%)

Merging #12902 into master will decrease coverage by <.01%

@@             master     #12902   diff @@
==========================================
  Files           466        466          
  Lines         69655      69636    -19   
  Methods        2128       2128          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          37752      37735    -17   
+ Misses        31903      31901     -2   
  Partials          0          0          

Powered by Codecov. Last update 179a86b...583e5e6

@nijel nijel merged commit bda8444 into phpmyadmin:master Jan 18, 2017

2 of 4 checks passed

codecov/patch 33.33% of diff hit (target 54.19%)
Details
codecov/project 54.18% (-0.01%) compared to 179a86b
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel
Member
nijel commented Jan 18, 2017

Looks good!

@nijel nijel self-assigned this Jan 18, 2017
@nijel nijel added this to the 4.7.0 milestone Jan 18, 2017
@ibennetch
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment