Replace Util::whichCrlf() with PHP_EOL #12919

Merged
merged 1 commit into from Jan 23, 2017

Projects

None yet

3 participants

@nijel
Member
nijel commented Jan 23, 2017 edited

It's available since PHP 5.0.2 so it's really time to use it.

Signed-off-by: Michal Čihař michal@cihar.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@nijel nijel Replace Util::whichCrlf() with PHP_EOL
It's available since PHP 5.0.2 so it's really time to use it.

Signed-off-by: Michal Čihař <michal@cihar.com>
75ad097
@nijel nijel self-assigned this Jan 23, 2017
@ibennetch

I don't suppose it makes much sense to continue testing here, since this is now a PHP constant any test failures would mean a bug with PHP itself.

@ibennetch
Contributor

Looks like a good plan to me.

@codecov-io
codecov-io commented Jan 23, 2017 edited

Current coverage is 54.18% (diff: 0.00%)

Merging #12919 into master will decrease coverage by <.01%

@@             master     #12919   diff @@
==========================================
  Files           466        466          
  Lines         69635      69629     -6   
  Methods        2126       2125     -1   
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          37733      37727     -6   
  Misses        31902      31902          
  Partials          0          0          

Powered by Codecov. Last update f4023ee...75ad097

@nijel nijel merged commit 9a3ec23 into phpmyadmin:master Jan 23, 2017

2 of 4 checks passed

codecov/patch 0.00% of diff hit (target 54.18%)
Details
codecov/project 54.18% (-0.01%) compared to f4023ee
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel nijel deleted the nijel:php-eol branch Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment