Google reCaptcha feature #13011
Google reCaptcha feature #13011
Conversation
ShreyasSinha
force-pushed
the
google_captcha
branch
2 times, most recently
from
bd3461b
to
47b51c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #13011 +/- ##
==========================================
+ Coverage 54.25% 54.25% +<.01%
==========================================
Files 466 466
Lines 69644 69645 +1
==========================================
+ Hits 37783 37784 +1
Misses 31861 31861Continue to review full report at Codecov.
|
js/functions.js
Outdated
| /* | ||
| * Function to enable the 'Go' button on login. | ||
| */ | ||
| function captcha_enable() { |
There was a problem hiding this comment.
I think this implies enabling the captcha itself, not the "Go" button.
Perhaps a better function name would be login_go_button_enable() or something else more descriptive.
There was a problem hiding this comment.
Yes, that will be better.
js/functions.js
Outdated
| /* | ||
| * Function to disable the 'Go' button on login. | ||
| */ | ||
| function captcha_disable() { |
There was a problem hiding this comment.
Likewise, this function name is also a bit misleading.
js/functions.js
Outdated
| @@ -5022,6 +5022,28 @@ function toggleDatepickerIfInvalid($td, $input_field) { | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
| * Function to enable the 'Go' button on login. | |||
There was a problem hiding this comment.
Please align the asterisks by indenting by one space, like
/*
* Function...
*/
That way it matches the style of the rest of the file.
|
Sadly, I am not a programmer. But do have still plenty ideas about new functions on phpMyAdmin. |
|
@edwarddekker Your input is valuable here. Thanks for taking an interest in improving the project. To be clear in case I caused confusion, my feedback was specifically meant about the code that ShreyasSinha has proposed. You can feel free to keep making suggestions :) |
ShreyasSinha
force-pushed
the
google_captcha
branch
from
47b51c3
to
dc9284d
Compare
Signed-off-by: Shreyas Sinha <shreyas.sinha14@gmail.com>
ShreyasSinha
force-pushed
the
google_captcha
branch
from
dc9284d
to
c433b57
Compare
|
@ibennetch I think this is ready for review. |
- use camel case for function names - move initialization to existing on load block Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
|
Merged with coding style cleanup in 1f819d8. |
|
Thanks @ShreyasSinha |
Signed-off-by: Shreyas Sinha shreyas.sinha14@gmail.com
Solves issue #12983
Before submitting pull request, please check that every commit: