Run Twig in degraded mode if cache is not available. #13227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #13225. Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #13227 +/- ##
==========================================
+ Coverage 54.4% 54.4% +<.01%
==========================================
Files 470 470
Lines 69905 69906 +1
==========================================
+ Hits 38034 38035 +1
Misses 31871 31871 |
nijel
reviewed
May 4, 2017
| $this->twig = new Twig_Environment($loader, array( | ||
| 'auto_reload' => true, | ||
| 'cache' => CACHE_DIR . 'twig', | ||
| 'cache' => is_writable($cache_dir) ? $cache_dir : false, |
There was a problem hiding this comment.
This will fail if the directory does not exist (what it always true on first run). It's probably better to try to create the dir if it does not exist (Twig would try to create it).
|
I've taken a bit more complex approach on this, it would be great if you could review #13237. |
|
Merged #13237 which addresses this in wider context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13225.
Signed-off-by: Dan Ungureanu udan1107@gmail.com
Before submitting pull request, please check that every commit: