Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow designer to show tables from other DB #13455

Merged
merged 1 commit into from Aug 14, 2017

Conversation

@Achilles-96
Copy link
Contributor

@Achilles-96 Achilles-96 commented Jul 8, 2017

Signed-off-by: Raghuram Vadapalli raghuram.4350@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov
Copy link

@codecov codecov bot commented Jul 8, 2017

Codecov Report

Merging #13455 into master will decrease coverage by 0.01%.
The diff coverage is 3.33%.

@@            Coverage Diff             @@
##           master   #13455      +/-   ##
==========================================
- Coverage   52.54%   52.52%   -0.02%     
==========================================
  Files         467      467              
  Lines       81374    81394      +20     
==========================================
+ Hits        42754    42755       +1     
- Misses      38620    38639      +19

@ibennetch ibennetch self-assigned this Jul 10, 2017
@ibennetch
Copy link
Member

@ibennetch ibennetch commented Jul 10, 2017

This functions well except I don't seem to be able to save the layout with the other database's table showing. I can save and open the view, but the other table isn't shown.

@Achilles-96
Copy link
Contributor Author

@Achilles-96 Achilles-96 commented Jul 10, 2017

Yeah. I knew that. That is the part I was referring the other day. The code for showing those tables is not easy to deal with. $GLOBALS is modified at many places and all. As promised, I will look into it later.

@ibennetch
Copy link
Member

@ibennetch ibennetch commented Jul 12, 2017

Oh, right, we were talking about that...it's just hard for me to associate that conversation with this pull request, it's like a different context and I just missing making the connection.

'SHOW INDEX FROM ' . PhpMyAdmin\Util::backquote($db)
. '.' . PhpMyAdmin\Util::backquote($T2) . ';'
'SHOW INDEX FROM ' . PMA\libraries\Util::backquote($DB2)
. '.' . PMA\libraries\Util::backquote($T2) . ';'
Copy link
Contributor

@nijel nijel Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're reverting namespace changes, this won't work...

Signed-off-by: Raghuram Vadapalli <raghuram.4350@gmail.com>
@ibennetch ibennetch merged commit c7264e5 into phpmyadmin:master Aug 14, 2017
4 of 6 checks passed
@ibennetch
Copy link
Member

@ibennetch ibennetch commented Aug 14, 2017

Merged, thanks!

ibennetch added a commit that referenced this issue Aug 14, 2017
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@ibennetch ibennetch added this to the 4.8.0 milestone Aug 14, 2017
@ibennetch
Copy link
Member

@ibennetch ibennetch commented Aug 14, 2017

I made a few minor fixes, as we discussed, changing the double quotes to single quotes is 22ddc46 and I removed a line that seems to be debugging code at 486daec.

I've also opened issues #13586 to add an icon and #13587 which are related to this feature.

Way to go. This is a very complex and fragile part of the code and you did a nice job.

@Achilles-96
Copy link
Contributor Author

@Achilles-96 Achilles-96 commented Aug 14, 2017

Thanks a lot, Isaac. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants