New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User configuration handling (base code) #13551

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
1 participant
@nijel
Member

nijel commented Aug 2, 2017

Consolidation of user settings as described in #13466.

Currently work in progress.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@nijel nijel referenced this pull request Aug 2, 2017

Closed

Share user settings for persistent choices made in the UI #13466

10 of 12 tasks complete
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 2, 2017

Codecov Report

Merging #13551 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13551      +/-   ##
==========================================
- Coverage   53.83%   53.82%   -0.01%     
==========================================
  Files         493      493              
  Lines       81019    81033      +14     
==========================================
  Hits        43614    43614              
- Misses      37405    37419      +14

codecov bot commented Aug 2, 2017

Codecov Report

Merging #13551 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13551      +/-   ##
==========================================
- Coverage   53.83%   53.82%   -0.01%     
==========================================
  Files         493      493              
  Lines       81019    81033      +14     
==========================================
  Hits        43614    43614              
- Misses      37405    37419      +14
Initial javascript API for handling user configuration
There ar now configGet/configSet functions which can be used to
manipulate user settings.

Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel changed the title from WIP: User configuration handling to User configuration handling (base code) Nov 28, 2017

@nijel nijel self-assigned this Nov 28, 2017

@nijel nijel added this to the 4.8.0 milestone Nov 28, 2017

@nijel nijel merged commit 2442877 into phpmyadmin:master Nov 28, 2017

3 of 5 checks passed

codecov/patch 0% of diff hit (target 53.83%)
Details
codecov/project 53.82% (-0.01%) compared to 80e90bf
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 9 new issues, 4 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nijel nijel deleted the nijel:userconfig-js branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment