New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13512 Patch #13590

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@anantjain6
Contributor

anantjain6 commented Aug 16, 2017

#13512 Patch

Signed-off-by: Anant Jain anantjain60@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
#13512 Pathch
#13512 Pathch
@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Aug 16, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

phpmyadmin-bot commented on 46bd6a9 Aug 16, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 16, 2017

Codecov Report

Merging #13590 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13590      +/-   ##
==========================================
- Coverage    53.2%    53.2%   -0.01%     
==========================================
  Files         466      466              
  Lines       81341    81349       +8     
==========================================
  Hits        43281    43281              
- Misses      38060    38068       +8

codecov bot commented Aug 16, 2017

Codecov Report

Merging #13590 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13590      +/-   ##
==========================================
- Coverage    53.2%    53.2%   -0.01%     
==========================================
  Files         466      466              
  Lines       81341    81349       +8     
==========================================
  Hits        43281    43281              
- Misses      38060    38068       +8
@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Aug 17, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

phpmyadmin-bot commented on b3682ef Aug 17, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@nijel nijel self-assigned this Aug 21, 2017

@nijel nijel added this to the 4.7.4 milestone Aug 21, 2017

nijel added a commit that referenced this pull request Aug 21, 2017

Do not hardcode width of button elements
Fixes #13512, #13590

Signed-off-by: Anant Jain <anantjain60@gmail.com>

nijel added a commit that referenced this pull request Aug 21, 2017

Apply #13590 to the original theme as well
Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this pull request Aug 21, 2017

Changelog entry for #13512 and #13590
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Aug 21, 2017

Member

Thanks, I've merged your patch as 2814305.

Member

nijel commented Aug 21, 2017

Thanks, I've merged your patch as 2814305.

@nijel nijel closed this Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment