New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random selenium failure tests #13594

Merged
merged 5 commits into from Aug 21, 2017

Conversation

Projects
None yet
2 participants
@devenbansod
Member

devenbansod commented Aug 18, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Issue #13591

devenbansod added some commits Aug 17, 2017

Fix createRemoveUser and TableBrowse::DeleteRecords
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Try using dynamic wait in TableBrowse and TableStructure
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Fix DbEvents test
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 18, 2017

Codecov Report

Merging #13594 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13594      +/-   ##
==========================================
+ Coverage    53.2%   53.24%   +0.03%     
==========================================
  Files         466      466              
  Lines       81349    81414      +65     
==========================================
+ Hits        43281    43345      +64     
- Misses      38068    38069       +1

codecov bot commented Aug 18, 2017

Codecov Report

Merging #13594 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13594      +/-   ##
==========================================
+ Coverage    53.2%   53.24%   +0.03%     
==========================================
  Files         466      466              
  Lines       81349    81414      +65     
==========================================
+ Hits        43281    43345      +64     
- Misses      38068    38069       +1

devenbansod added some commits Aug 20, 2017

Fix another possible failure point in DbEvents - testAddEvent
See: https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/266409700 for example

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Clear input fields to avoid duplicate texts
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

@nijel nijel self-assigned this Aug 21, 2017

@nijel nijel added this to the 4.8.0 milestone Aug 21, 2017

@nijel nijel merged commit dac19fb into phpmyadmin:master Aug 21, 2017

6 checks passed

DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 4 updated code elements – Tests: passed
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing b146b91...94d8d89
Details
codecov/project 53.24% (+0.03%) compared to b146b91
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Aug 21, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Aug 21, 2017

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment