New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13593 : removed whitespace in textarea for column default value #13597

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
2 participants
@nehalko3087
Contributor

nehalko3087 commented Aug 20, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fix #13593 : removed whitespace in textarea for column default value
Signed-off-by: Neha Parihar Sinha <nehalko3087@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 20, 2017

Codecov Report

Merging #13597 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13597   +/-   ##
=======================================
  Coverage   53.24%   53.24%           
=======================================
  Files         466      466           
  Lines       81414    81414           
=======================================
  Hits        43345    43345           
  Misses      38069    38069

codecov bot commented Aug 20, 2017

Codecov Report

Merging #13597 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13597   +/-   ##
=======================================
  Coverage   53.24%   53.24%           
=======================================
  Files         466      466           
  Lines       81414    81414           
=======================================
  Hits        43345    43345           
  Misses      38069    38069

@nijel nijel self-assigned this Aug 21, 2017

@nijel nijel added this to the 4.8.0 milestone Aug 21, 2017

@nijel nijel merged commit 391d6c8 into phpmyadmin:master Aug 21, 2017

6 checks passed

DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing 0932f25...7c8e33b
Details
codecov/project 53.24% remains the same compared to 0932f25
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Aug 21, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Aug 21, 2017

Merged, thanks for your contribution!

@nehalko3087

This comment has been minimized.

Show comment
Hide comment
@nehalko3087

nehalko3087 Aug 21, 2017

Contributor

My Pleasure :)

Contributor

nehalko3087 commented Aug 21, 2017

My Pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment