New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring in Selenium tests #13605

Merged
merged 3 commits into from Aug 22, 2017

Conversation

Projects
None yet
2 participants
@devenbansod
Member

devenbansod commented Aug 22, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Issue #13591

devenbansod added some commits Aug 21, 2017

Refactor methods in selenium tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Replace usleep with sleep calls
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Add navigateDatabase method to prevent navigation errors
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 22, 2017

Codecov Report

Merging #13605 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13605   +/-   ##
=======================================
  Coverage   53.23%   53.23%           
=======================================
  Files         466      466           
  Lines       81492    81492           
=======================================
  Hits        43382    43382           
  Misses      38110    38110

codecov bot commented Aug 22, 2017

Codecov Report

Merging #13605 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13605   +/-   ##
=======================================
  Coverage   53.23%   53.23%           
=======================================
  Files         466      466           
  Lines       81492    81492           
=======================================
  Hits        43382    43382           
  Misses      38110    38110

@nijel nijel merged commit 8256945 into phpmyadmin:master Aug 22, 2017

5 checks passed

DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 6 updated code elements – Tests: passed
Details
codecov/patch Coverage not affected when comparing 36d8d98...b72b5ab
Details
codecov/project 53.23% remains the same compared to 36d8d98
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Aug 22, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Aug 22, 2017

Merged, thanks for your contribution!

@nijel nijel self-assigned this Aug 22, 2017

@nijel nijel added this to the 4.8.0 milestone Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment