New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitgnore ".github" folder #13632

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@acs-ferreira
Contributor

acs-ferreira commented Sep 2, 2017

No description provided.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 2, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@d877a0b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13632   +/-   ##
=========================================
  Coverage          ?   53.24%           
=========================================
  Files             ?      468           
  Lines             ?    81024           
  Branches          ?        0           
=========================================
  Hits              ?    43140           
  Misses            ?    37884           
  Partials          ?        0

codecov bot commented Sep 2, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@d877a0b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13632   +/-   ##
=========================================
  Coverage          ?   53.24%           
=========================================
  Files             ?      468           
  Lines             ?    81024           
  Branches          ?        0           
=========================================
  Hits              ?    43140           
  Misses            ?    37884           
  Partials          ?        0
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Sep 4, 2017

Member

We use the .github folder, so it certainly should not be ignored: https://github.com/phpmyadmin/phpmyadmin/tree/master/.github

What are you actually trying to achieve?

Member

nijel commented Sep 4, 2017

We use the .github folder, so it certainly should not be ignored: https://github.com/phpmyadmin/phpmyadmin/tree/master/.github

What are you actually trying to achieve?

@nijel nijel closed this Sep 4, 2017

@nijel nijel self-assigned this Sep 4, 2017

@acs-ferreira

This comment has been minimized.

Show comment
Hide comment
@acs-ferreira

acs-ferreira Sep 4, 2017

Contributor

What's the local use of that folder? Shouldn't it remain in github only?

Contributor

acs-ferreira commented Sep 4, 2017

What's the local use of that folder? Shouldn't it remain in github only?

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Sep 4, 2017

Member

The local use is to be able to edit those files - it's configuration for GitHub issue tracking.

Member

nijel commented Sep 4, 2017

The local use is to be able to edit those files - it's configuration for GitHub issue tracking.

@acs-ferreira

This comment has been minimized.

Show comment
Hide comment
@acs-ferreira

acs-ferreira Sep 4, 2017

Contributor

OK, so no local (production) use.
No problem, as many other projects just .gitignore it, i've submitted this PR, but if it is non-sense, just keep it closed :)

Contributor

acs-ferreira commented Sep 4, 2017

OK, so no local (production) use.
No problem, as many other projects just .gitignore it, i've submitted this PR, but if it is non-sense, just keep it closed :)

nijel added a commit that referenced this pull request Sep 4, 2017

Ignore some development files when exporting Git
Fixes #13632

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Sep 4, 2017

Member

Well the files in git serve development purposes as well :-). The releases do not contain those. I've added .gitattributes to avoid shipping them using composer in f407601.

Member

nijel commented Sep 4, 2017

Well the files in git serve development purposes as well :-). The releases do not contain those. I've added .gitattributes to avoid shipping them using composer in f407601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment