New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config descriptions #13646

Merged
merged 8 commits into from Sep 5, 2017

Conversation

Projects
None yet
1 participant
@nijel
Member

nijel commented Sep 5, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@nijel nijel self-assigned this Sep 5, 2017

@nijel nijel added this to the 4.8.0 milestone Sep 5, 2017

Avoid defining error messages centrally in server config check
- better load them only when needed
- avoid using PMA_lang which really serves different purpose

Signed-off-by: Michal Čihař <michal@cihar.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 5, 2017

Codecov Report

Merging #13646 into master will increase coverage by 0.18%.
The diff coverage is 94.01%.

@@            Coverage Diff             @@
##           master   #13646      +/-   ##
==========================================
+ Coverage   53.22%   53.41%   +0.18%     
==========================================
  Files         468      467       -1     
  Lines       81700    82113     +413     
==========================================
+ Hits        43483    43857     +374     
- Misses      38217    38256      +39

codecov bot commented Sep 5, 2017

Codecov Report

Merging #13646 into master will increase coverage by 0.18%.
The diff coverage is 94.01%.

@@            Coverage Diff             @@
##           master   #13646      +/-   ##
==========================================
+ Coverage   53.22%   53.41%   +0.18%     
==========================================
  Files         468      467       -1     
  Lines       81700    82113     +413     
==========================================
+ Hits        43483    43857     +374     
- Misses      38217    38256      +39

nijel added some commits Sep 5, 2017

Refactor configuration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
Use Url::getCommon to generate full URLs
Signed-off-by: Michal Čihař <michal@cihar.com>
Move tests for ServerConfigChecks class to separate file
Signed-off-by: Michal Čihař <michal@cihar.com>
Split up tests for ServerConfigChecks
Signed-off-by: Michal Čihař <michal@cihar.com>
Wrap function_exists in ServerConfigChecks to allow testing
Signed-off-by: Michal Čihař <michal@cihar.com>
Add tests for getting all configuration descriptions
Signed-off-by: Michal Čihař <michal@cihar.com>
Remove unused strings
Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel merged commit 4b983d6 into phpmyadmin:master Sep 5, 2017

1 of 3 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer Analysis: 17 updated code elements – Tests: passed
Details

@nijel nijel deleted the nijel:config-messages branch Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment