New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups in DBI #13656

Merged
merged 3 commits into from Sep 6, 2017

Conversation

Projects
None yet
1 participant
@nijel
Member

nijel commented Sep 6, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@nijel nijel self-assigned this Sep 6, 2017

@nijel nijel added this to the 4.8.0 milestone Sep 6, 2017

nijel added some commits Sep 6, 2017

Move mysqli flag description sot Dbi class
Signed-off-by: Michal Čihař <michal@cihar.com>
Move databaase interface load to static method
Signed-off-by: Michal Čihař <michal@cihar.com>
Remove unused define PMA_MYSQL_CLIENT_API
Remove PMA_MYSQL_CLIENT_API and all logic for defining it.

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel merged commit 0b38452 into phpmyadmin:master Sep 6, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details

@nijel nijel deleted the nijel:dbi-cleanup branch Sep 6, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 6, 2017

Codecov Report

Merging #13656 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13656      +/-   ##
==========================================
+ Coverage   53.85%   53.86%   +<.01%     
==========================================
  Files         481      477       -4     
  Lines       81866    81824      -42     
==========================================
- Hits        44093    44076      -17     
+ Misses      37773    37748      -25

codecov bot commented Sep 6, 2017

Codecov Report

Merging #13656 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13656      +/-   ##
==========================================
+ Coverage   53.85%   53.86%   +<.01%     
==========================================
  Files         481      477       -4     
  Lines       81866    81824      -42     
==========================================
- Hits        44093    44076      -17     
+ Misses      37773    37748      -25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment